GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109162: libregrtest: fix _decode_worker_job() by vstinner · Pull Request #109202 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 9, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Decode also HuntRefleak() object inside the RunTests object.

Add an unit test on huntrleaks with multiprocessing (-R -jN).

  • Issue: Refactor test.libregrtest #109162

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-109162: libregrtest: fix _decode_worker_job()
833c6dc 
Decode also HuntRefleak() object inside the RunTests object.

Add an unit test on huntrleaks with multiprocessing (-R -jN).
@vstinner vstinner added the skip news label Sep 9, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Sep 9, 2023
@bedevere-bot bedevere-bot mentioned this pull request Sep 9, 2023
Refactor test.libregrtest #109162
Closed
@vstinner vstinner mentioned this pull request Sep 9, 2023
gh-109162: Refactor libregrtest.RunTests #109177
Merged
@AlexWaygood AlexWaygood added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Sep 9, 2023
@bedevere-bot

bedevere-bot commented Sep 9, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @AlexWaygood for commit 833c6dc 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Sep 9, 2023
@vstinner
vstinner merged commit 24fa8f2 into python:main Sep 9, 2023
@vstinner
vstinner deleted the regrtest_refactor7 branch September 9, 2023 22:51
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 9, 2023
@vstinner

vstinner commented Sep 9, 2023

Copy link
Copy Markdown
Member Author

🤖 New build scheduled with the buildbot fleet by @AlexWaygood for commit 833c6dc 🤖

Oh, I tested the exact command used by buildbots locally and I validated that my change fix this command.

I also added an unit test to check for non-regression.

I merged my PR since I would like to create following pull requests which rely on this fix.
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood

AlexWaygood commented Sep 9, 2023

Copy link
Copy Markdown
Member

Oh, I tested the exact command used by buildbots locally and I validated that my change fix this command.

No worries! Some of the buildbots were already coming back green anyway, so I'm pretty confident we're okay here :-)

Thanks for the quick fix!
vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Sep 9, 2023

Copy link
Copy Markdown
Member Author

I merged my PR since I would like to create following pull requests which rely on this fix.

Following PR: PR #109204.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @bedevere-bot @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.