GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109162: libregrtest: remove WorkerJob class by vstinner · Pull Request #109204 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 9, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

  • Add attributes to Regrtest and RunTests:

    • gc_threshold
    • memory_limit
    • python_cmd
    • use_resources

  • Remove WorkerJob class. Add as_json() and from_json() methods to RunTests. A worker process now only uses RunTests for all parameters.

  • Add tests on support.set_memlimit() in test_support. Create _parse_memlimit() and also adds tests on it.

  • Remove 'ns' parameter from runtest.py.

  • Issue: Refactor test.libregrtest #109162

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-109162: libregrtest: remove WorkerJob class
d0c37de 
* Add attributes to Regrtest and RunTests:

  * gc_threshold
  * memory_limit
  * python_cmd
  * use_resources

* Remove WorkerJob class. Add as_json() and from_json() methods to
  RunTests. A worker process now only uses RunTests for all
  parameters.
* Add tests on support.set_memlimit() in test_support. Create
  _parse_memlimit() and also adds tests on it.
* Remove 'ns' parameter from runtest.py.
@vstinner vstinner added the skip news label Sep 9, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Sep 9, 2023
@bedevere-bot bedevere-bot mentioned this pull request Sep 9, 2023
Refactor test.libregrtest #109162
Closed
@vstinner vstinner mentioned this pull request Sep 9, 2023
gh-109162: libregrtest: fix _decode_worker_job() #109202
Merged
@vstinner
vstinner merged commit 0c0f254 into python:main Sep 9, 2023
@vstinner
vstinner deleted the regrtest_refactor8 branch September 9, 2023 23:41
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.