GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix a typo by Son-Dongwoo · Pull Request #109213 · python/cpython

Conversation

@Son-Dongwoo

@Son-Dongwoo Son-Dongwoo commented Sep 10, 2023

Copy link
Copy Markdown
Contributor

The word "becaose" seems a typo. This PR corrects the typo to "because".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
dnd-qodqks
fix a typo
9b7a89b
@bedevere-bot bedevere-bot added the awaiting review label Sep 10, 2023
@bedevere-bot

bedevere-bot commented Sep 10, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sunmy2019
sunmy2019 approved these changes Sep 10, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Sep 10, 2023
@sunmy2019 sunmy2019 added skip issue skip news labels Sep 10, 2023
@serhiy-storchaka

serhiy-storchaka commented Sep 10, 2023

Copy link
Copy Markdown
Member

There is another typo in this line.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
dcollison
dcollison reviewed Sep 15, 2023
View reviewed changes
Comment thread Tools/c-analyzer/c_parser/info.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka requested a review from ericsnowcurrently September 15, 2023 15:01
ericsnowcurrently
ericsnowcurrently approved these changes Sep 15, 2023
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with @dcollison's recommended fix)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericsnowcurrently

ericsnowcurrently commented Sep 15, 2023

Copy link
Copy Markdown
Member

(I really need to use a spell-checker! 😆)
dcollison reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sunmy2019 @dcollison
Update Tools/c-analyzer/c_parser/info.py
1a646c4 
Co-authored-by: Dale Collison <[email protected]>
@sunmy2019

sunmy2019 commented Sep 17, 2023

Copy link
Copy Markdown
Member

@ericsnowcurrently Can you land it?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sunmy2019
Merge branch 'main' into fix_typo
90f991c
@hauntsaninja
hauntsaninja merged commit df8b3a4 into python:main Sep 18, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 18, 2023
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@Son-Dongwoo @sunmy2019
@dcollison @csm10495
Fix a typo in c-analyzer (python#109213)
5e484bf 
Co-authored-by: sunmy2019 <[email protected]>
Co-authored-by: Dale Collison <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes
@sunmy2019 sunmy2019 sunmy2019 approved these changes
+1 more reviewer
@dcollison dcollison dcollison left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@Son-Dongwoo @bedevere-bot @serhiy-storchaka @ericsnowcurrently @sunmy2019 @dcollison @hauntsaninja
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.