GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109276: libregrtest only checks saved_test_environment() once by vstinner · Pull Request #109278 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 11, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There is no need to check for environment changes twice.

  • Issue: Enhance Python regrtest test runner (test.libregrtest) #109276

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-109276: libregrtest only checks saved_test_environment() once
a0da31a 
There is no need to check for environment changes twice.
@bedevere-app bedevere-app Bot added the awaiting review label Sep 11, 2023
@vstinner vstinner added the skip news label Sep 11, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 11, 2023
Enhance Python regrtest test runner (test.libregrtest) #109276
Closed
@vstinner

vstinner commented Sep 11, 2023

Copy link
Copy Markdown
Member Author

@serhiy-storchaka: I think that you reported this issue once somewhere, I don't recall where.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka self-requested a review September 11, 2023 17:14
serhiy-storchaka
serhiy-storchaka approved these changes Sep 11, 2023
View reviewed changes
Comment thread Lib/test/libregrtest/single.py Outdated
Comment on lines +136 to +137
runtests.quiet,
pgo=runtests.pgo):

@serhiy-storchaka serhiy-storchaka Sep 11, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quiet and pgo are already local variables.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 11, 2023
@vstinner
use local variables
55765a5
@vstinner
vstinner merged commit 4e77645 into python:main Sep 12, 2023
@vstinner
vstinner deleted the regrtest_save_env branch September 12, 2023 03:01
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 12, 2023
vstinner added a commit to vstinner/cpython that referenced this pull request Sep 13, 2023
@vstinner
pythongh-109276: libregrtest only checks saved_test_environment() once (
fd67616 
python#109278)

There is no need to check for environment changes twice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.