GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109276: libregrtest: limit number workers by vstinner · Pull Request #109288 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 11, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Don't spawn more threads than the number of jobs: these worker threads would never get anything to do.

Add RunTests.get_jobs() method.

  • Issue: Enhance Python regrtest test runner (test.libregrtest) #109276

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner vstinner added the skip news label Sep 11, 2023
@bedevere-app bedevere-app Bot added the awaiting review label Sep 11, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 11, 2023
Enhance Python regrtest test runner (test.libregrtest) #109276
Closed
@vstinner
pythongh-109276: libregrtest: limit number workers
b68232c 
Don't spawn more threads than the number of jobs: these worker
threads would never get anything to do.

* Add the number of tests in "Run ... tests in ..." message.
* Add RunTests.get_jobs() method.
* Add plural() function.
* count() uses f-string.
@vstinner
vstinner force-pushed the regrtest_num_workers branch from 5cc6ae9 to b68232c Compare September 12, 2023 02:56
@vstinner
vstinner enabled auto-merge (squash) September 12, 2023 03:34
@vstinner
vstinner merged commit 8c813fa into python:main Sep 12, 2023
@vstinner
vstinner deleted the regrtest_num_workers branch September 12, 2023 03:47
@bedevere-app bedevere-app Bot removed the awaiting review label Sep 12, 2023
vstinner added a commit to vstinner/cpython that referenced this pull request Sep 13, 2023
@vstinner
pythongh-109276: libregrtest: limit number workers (python#109288)
96ef258 
Don't spawn more threads than the number of jobs: these worker
threads would never get anything to do.

* Add the number of tests in "Run ... tests in ..." message.
* Add RunTests.get_jobs() method.
* Add plural() function.
* count() uses f-string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.