GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109276: libregrtest: fix work dir on WASI by vstinner · Pull Request #109356 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 13, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

On WASI platform, get_temp_dir() should behave differently since the parent process is a WASI process and uses a different get_temp_dir() path.

Fix also WorkerThread._runtest(): don't read JSON file if the worker process exit code is non-zero.

  • Issue: Enhance Python regrtest test runner (test.libregrtest) #109276

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-109276: libregrtest: fix work dir on WASI
ce06a36 
On WASI platform, get_temp_dir() should behave differently since the
parent process is a WASI process and uses a different get_temp_dir()
path.

Fix also WorkerThread._runtest(): don't read JSON file if the worker
process exit code is non-zero.
@vstinner vstinner added the skip news label Sep 13, 2023
@bedevere-app bedevere-app Bot added the awaiting review label Sep 13, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 13, 2023
Enhance Python regrtest test runner (test.libregrtest) #109276
Closed
@vstinner

vstinner commented Sep 13, 2023

Copy link
Copy Markdown
Member Author

!buildbot wasm32-wasi
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Sep 13, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit ce06a36 🤖

The command will test the builders whose names match following regular expression: wasm32-wasi

The builders matched are:

  • wasm32-wasi PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Sep 13, 2023
gh-109276: libregrtest: WASM use stdout for JSON #109355
Merged
@vstinner
Fix typo
7e02048
@vstinner

vstinner commented Sep 13, 2023

Copy link
Copy Markdown
Member Author

!buildbot wasm32-wasi
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Sep 13, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 7e02048 🤖

The command will test the builders whose names match following regular expression: wasm32-wasi

The builders matched are:

  • wasm32-wasi PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Sep 13, 2023

Copy link
Copy Markdown
Member Author

Nice! WASI buildbot pass again with this fix!

Total test files: run=460/463 skipped=143 resource_denied=3
Result: SUCCESS
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner enabled auto-merge (squash) September 13, 2023 01:21
@vstinner
vstinner merged commit b544c2b into python:main Sep 13, 2023
@vstinner
vstinner deleted the regrtest_wasi branch September 13, 2023 01:40
@bedevere-app bedevere-app Bot removed the awaiting review label Sep 13, 2023
vstinner added a commit to vstinner/cpython that referenced this pull request Sep 13, 2023
@vstinner
pythongh-109276: libregrtest: fix work dir on WASI (python#109356)
56fbeab 
On WASI platform, get_temp_dir() should behave differently since the
parent process is a WASI process and uses a different get_temp_dir()
path.

Fix also WorkerThread._runtest(): don't read JSON file if the worker
process exit code is non-zero.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.