GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109414: Add some basic information about venvs in the introduction. by vsajip · Pull Request #109440 · python/cpython

Conversation

@vsajip

@vsajip vsajip commented Sep 15, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Add a note to the venv documentation that users should **not** put their code _inside_ the virtual environment #109414

📚 Documentation preview 📚: https://cpython-previews--109440.org.readthedocs.build/en/109440/library/venv.html

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vsajip
pythongh-109414: Add some basic information about venvs in the introd…
5450d88 
…uction.
@vsajip vsajip added the docs Documentation in the Doc dir label Sep 15, 2023
@bedevere-app bedevere-app Bot added awaiting review skip news labels Sep 15, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 15, 2023
Add a note to the venv documentation that users should **not** put their code _inside_ the virtual environment #109414
Closed
@vsajip
vsajip requested a review from brettcannon September 15, 2023 08:45
vstinner
vstinner reviewed Sep 15, 2023
View reviewed changes
Comment thread Doc/library/venv.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/venv.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Sep 15, 2023

Copy link
Copy Markdown
Member

I'm using venv as a sandbox to install libraries that I don't want to install system-wide, but your definition implies that.

I'm also using them to modify the code: it's convenient to develop, since changes are "undone" when I remove (and recreate) the venv.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Sep 15, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I made some suggestions, but you can ignore them ;-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 15, 2023
@vsajip @vstinner
Apply suggestions from code review
43a2f95 
Co-authored-by: Victor Stinner <[email protected]>
@vsajip

vsajip commented Sep 15, 2023

Copy link
Copy Markdown
Member Author

I'm using venv as a sandbox to install libraries that I don't want to install system-wide, but your definition implies that.

I'm also using them to modify the code

Yes, the list isn't meant to be exhaustive 😉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vsajip
Make additional changes to wording.
6adcdd1
vstinner
vstinner approved these changes Sep 15, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the minor updates 😉

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
brettcannon
brettcannon approved these changes Sep 15, 2023
View reviewed changes
@vsajip
vsajip merged commit a6846d4 into python:main Sep 16, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 16, 2023
@vsajip
vsajip deleted the fix-109414 branch September 16, 2023 08:49
@vsajip vsajip added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 16, 2023
@miss-islington

miss-islington commented Sep 16, 2023

Copy link
Copy Markdown
Contributor

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Sep 16, 2023

Copy link
Copy Markdown
Contributor

Thanks @vsajip for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2023
@vsajip @vstinner @miss-islington
pythongh-109414: Add some basic information about venvs in the introd…
0d584d7 
…uction. (pythonGH-109440)

(cherry picked from commit a6846d4)

Co-authored-by: Vinay Sajip <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2023
@vsajip @vstinner @miss-islington
pythongh-109414: Add some basic information about venvs in the introd…
fbe857c 
…uction. (pythonGH-109440)

(cherry picked from commit a6846d4)

Co-authored-by: Vinay Sajip <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 16, 2023

Copy link
Copy Markdown

GH-109480 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Sep 16, 2023
@bedevere-app

bedevere-app Bot commented Sep 16, 2023

Copy link
Copy Markdown

GH-109481 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 16, 2023
vsajip pushed a commit that referenced this pull request Sep 16, 2023
@miss-islington
[3.11] gh-109414: Add some basic information about venvs in the intro…
e16a9af 
…duction. (GH-109440) (GH-109480)

(cherry picked from commit a6846d4)
Yhg1s pushed a commit that referenced this pull request Sep 17, 2023
@miss-islington @vsajip @vstinner
[3.12] gh-109414: Add some basic information about venvs in the intro…
6552879 
…duction. (GH-109440) (#109481)

gh-109414: Add some basic information about venvs in the introduction. (GH-109440)
(cherry picked from commit a6846d4)

Co-authored-by: Vinay Sajip <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@vsajip @vstinner @csm10495
pythongh-109414: Add some basic information about venvs in the introd…
b7ff008 
…uction. (pythonGH-109440)

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes
@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vsajip @vstinner @miss-islington @brettcannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.