GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109408: Remove Ubuntu unit tests from Azure Pipelines by hugovk · Pull Request #109452 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Sep 15, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Both ci.yml and pr.yml run Ubuntu_CI_Tests which runs .azure-pipelines/posix-steps.yml

.azure-pipelines/posix-steps.yml does:

  1. checkout/setup
  2. build Python
  3. display build info
  4. run unit tests
  5. run patchcheck (PR only)
  6. report unit test results

This PR removes the Ubuntu unit test run (4)/report (6), as we're running it on GitHub Actions.

Because patchcheck is only run for PRs (pr.yml), there's no point building Python and then doing nothing for ci.yml, so we can remove the whole Ubuntu_CI_Tests from ci.yml.

Finally, rename Ubuntu_CI_Tests to something more accurate: Ubuntu_Patchcheck.

This speeds up Ubunutu part of pr.yml from ~14 to ~4 mins, and ci.yml from ~14 to 0 mins.

  • Issue: Move Azure Pipelines CI to GitHub Actions #109408

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
hugovk added 4 commits September 15, 2023 16:29
@hugovk
Remove Ubuntu unit tests from Azure Pipelines
0a339fe
@hugovk
Inline single use variables
a2b2651
@hugovk
Remove Ubuntu_CI_Tests from ci.yml, it skips patchcheck
cfa0ad6
@hugovk
Rename Ubuntu_PR_Tests to Ubuntu_Patchcheck
775e6e8
@bedevere-app bedevere-app Bot added the awaiting review label Sep 15, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 15, 2023
Move Azure Pipelines CI to GitHub Actions #109408
Closed
@hugovk hugovk added skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 15, 2023
@sobolevn sobolevn mentioned this pull request Sep 15, 2023
gh-109408: Run patchcheck in GitHub Actions #109459
Closed
itamaro
itamaro approved these changes Sep 17, 2023
View reviewed changes

@itamaro itamaro left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 17, 2023
@hugovk
hugovk merged commit a75daed into python:main Sep 17, 2023
@hugovk
hugovk deleted the ap-rm-ubuntu-tests branch September 17, 2023 17:46
@miss-islington

miss-islington commented Sep 17, 2023

Copy link
Copy Markdown
Contributor

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 17, 2023
@miss-islington

miss-islington commented Sep 17, 2023

Copy link
Copy Markdown
Contributor

Sorry, @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker a75daed7e004ee9a53b160307c4c072656176a02 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 17, 2023
@hugovk @miss-islington
pythongh-109408: Remove Ubuntu unit tests from Azure Pipelines (pytho…
4f7e1bb 
…nGH-109452)

(cherry picked from commit a75daed)

Co-authored-by: Hugo van Kemenade <[email protected]>
@miss-islington miss-islington assigned hugovk Sep 17, 2023
@bedevere-app

bedevere-app Bot commented Sep 17, 2023

Copy link
Copy Markdown

GH-109519 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 17, 2023
@bedevere-app

bedevere-app Bot commented Sep 17, 2023

Copy link
Copy Markdown

GH-109520 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Sep 17, 2023
hugovk added a commit to hugovk/cpython that referenced this pull request Sep 17, 2023
@hugovk
[3.11] pythongh-109408: Remove Ubuntu unit tests from Azure Pipelines (…
28cceb8 
…pythonGH-109452)

(cherry picked from commit a75daed)

Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk added a commit that referenced this pull request Sep 17, 2023
@hugovk
[3.11] gh-109408: Remove Ubuntu unit tests from Azure Pipelines (GH-1…
e15b663 
…09452) (#109520)

(cherry picked from commit a75daed)
Yhg1s pushed a commit that referenced this pull request Sep 17, 2023
@miss-islington @hugovk
[3.12] gh-109408: Remove Ubuntu unit tests from Azure Pipelines (GH-1…
5c439fb 
…09452) (#109519)

gh-109408: Remove Ubuntu unit tests from Azure Pipelines (GH-109452)
(cherry picked from commit a75daed)

Co-authored-by: Hugo van Kemenade <[email protected]>
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@hugovk @csm10495
pythongh-109408: Remove Ubuntu unit tests from Azure Pipelines (pytho…
be22f09 
…n#109452)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itamaro itamaro itamaro approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@hugovk hugovk

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hugovk @miss-islington @itamaro
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.