GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109408: Azure Pipelines: test 3.12 branch by hugovk · Pull Request #109453 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Sep 15, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

As noted in #109408 (comment), Azure Pipelines CI (ci.yml) runs tests on version branches post-merge.

But it's only running on main and 3.11 and older, and not on 3.12, because we forgot to add it when branching 3.12 from main in May:

Screenshot

image

Also, Azure Pipelines PR (pr.yml) only runs for PRs to main, but I added the missing 3.12 anyway (and am planning on eventually removing it in #109408):

Screenshot

image

Should we remove 3.7 from these lists?

  • Issue: Move Azure Pipelines CI to GitHub Actions #109408

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added the awaiting review label Sep 15, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 15, 2023
Move Azure Pipelines CI to GitHub Actions #109408
Closed
@hugovk hugovk added the skip news label Sep 15, 2023
vstinner
vstinner reviewed Sep 15, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be added to PEP 101 release process to not forget it next time.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk

hugovk commented Sep 15, 2023

Copy link
Copy Markdown
Member Author

It should be added to PEP 101 release process to not forget it next time.

Looking at PEP 101, should it be added to https://github.com/python/release-tools/blob/master/release.py?

  • Bump version numbers via the release script:
    $ .../release-tools/release.py --bump X.Y.ZaN
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Sep 15, 2023

Copy link
Copy Markdown
Member

I didn't understand well the future of Azure Pipelines. If it goes away, updating the release tool is not needed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Sep 15, 2023

Copy link
Copy Markdown
Member Author

There are two Azure Pipelines runs.

One for PRs (pr.yml) - we're planning on removing this one, it's the one most people would notice.

The other runs on version branches after merging PRs (ci.yml), and it's not visible in PRs. Steve would like to keep this one running to do some extra Windows packaging checks (#109408 (comment)), so that can stay.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
Azure Pipelines: test 3.12 branch
d80dca1
@hugovk
hugovk force-pushed the ap-test-3.12 branch from 4abab47 to d80dca1 Compare September 18, 2023 09:27
@hugovk

hugovk commented Sep 18, 2023

Copy link
Copy Markdown
Member Author

Apologies for the force push, it was a mistake! No changes to the PR other than rebasing on main.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk mentioned this pull request Sep 18, 2023
Add newly created branch to Azure Pipelines python/release-tools#56
Closed
@hugovk

hugovk commented Sep 18, 2023

Copy link
Copy Markdown
Member Author

It should be added to PEP 101 release process to not forget it next time.

Looking at PEP 101, should it be added to python/release-tools@master/release.py?

  • Bump version numbers via the release script:
    $ .../release-tools/release.py --bump X.Y.ZaN

Issue created: python/release-tools#56
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Sep 18, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 18, 2023
@vstinner

vstinner commented Sep 18, 2023

Copy link
Copy Markdown
Member

The other runs on version branches after merging PRs (ci.yml), and it's not visible in PRs. Steve would like to keep this one running to do some extra Windows packaging checks (#109408 (comment)), so that can stay.

Sure, it makes sense. Thanks for the explanation.
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 18, 2023
@hugovk
hugovk merged commit dd5d214 into python:main Sep 18, 2023
@hugovk
hugovk deleted the ap-test-3.12 branch September 18, 2023 12:37
@miss-islington

miss-islington commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 18, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2023
@hugovk @miss-islington
pythongh-109408: Azure Pipelines: test 3.12 branch (pythonGH-109453)
8aac67a 
(cherry picked from commit dd5d214)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 18, 2023

Copy link
Copy Markdown

GH-109535 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2023
@hugovk @miss-islington
pythongh-109408: Azure Pipelines: test 3.12 branch (pythonGH-109453)
66bf57a 
(cherry picked from commit dd5d214)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 18, 2023
@bedevere-app

bedevere-app Bot commented Sep 18, 2023

Copy link
Copy Markdown

GH-109536 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Sep 18, 2023
hugovk added a commit that referenced this pull request Sep 18, 2023
@miss-islington @hugovk
[3.11] gh-109408: Azure Pipelines: test 3.12 branch (GH-109453) (#109536
26b75b8 
)

Co-authored-by: Hugo van Kemenade <[email protected]>
Yhg1s pushed a commit that referenced this pull request Sep 18, 2023
@miss-islington @hugovk
[3.12] gh-109408: Azure Pipelines: test 3.12 branch (GH-109453) (#109535
0620bc7 
)

gh-109408: Azure Pipelines: test 3.12 branch (GH-109453)
(cherry picked from commit dd5d214)

Co-authored-by: Hugo van Kemenade <[email protected]>
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@hugovk @csm10495
pythongh-109408: Azure Pipelines: test 3.12 branch (python#109453)
7c24e26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hugovk @vstinner @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.