GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109466: Add ipv6_mapped property to IPv4Address by csm10495 · Pull Request #109467 · python/cpython

Conversation

@csm10495

@csm10495 csm10495 commented Sep 15, 2023 •
edited by gpshead
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Updated docs and added a corresponding unit test.

  • Issue: Add ipv6_mapped property to IPv4Address #109466

Fixes #109466.

📚 Documentation preview 📚: https://cpython-previews--109467.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@csm10495
Add ipv6_mapped property to IPV4Address
c81d093
@bedevere-app bedevere-app Bot added the awaiting review label Sep 15, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 15, 2023
Add ipv6_mapped property to IPv4Address #109466
Closed
csm10495 added 3 commits September 15, 2023 12:34
@csm10495
lint
6db895f
@csm10495
lint
9bc999d
@csm10495
lint
b48b874
@csm10495

csm10495 commented Sep 23, 2023

Copy link
Copy Markdown
Contributor Author

@asvetlov I think you were a more recent committer here. Any chance for a review? Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@csm10495

csm10495 commented Oct 15, 2023

Copy link
Copy Markdown
Contributor Author

Friendly ping @asvetlov. Thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk changed the title gh-109466 Add ipv6_mapped property to IPV4Address gh-109466: Add ipv6_mapped property to IPV4Address Nov 5, 2023
hugovk
hugovk reviewed Nov 5, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let someone else review whether this is needed, but here's some docs suggestions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/ipaddress.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/ipaddress.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/ipaddress.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Library/2023-09-15-12-30-21.gh-issue-109466.6ah-aw.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.13.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
gpshead and others added 5 commits November 5, 2023 08:14
@gpshead @hugovk
Docstring update for ipv6_mapped
9fc3011 
Co-authored-by: Hugo van Kemenade <[email protected]>
@gpshead @hugovk
Update Misc/NEWS.d/next/Library/2023-09-15-12-30-21.gh-issue-109466.6…
f42dd16 
…ah-aw.rst

Co-authored-by: Hugo van Kemenade <[email protected]>
@gpshead @hugovk
Docstring update.
d78bf5a 
Co-authored-by: Hugo van Kemenade <[email protected]>
@gpshead @hugovk
Update Doc/whatsnew/3.13.rst
52ce9e9 
Co-authored-by: Hugo van Kemenade <[email protected]>
@gpshead @hugovk
Update Doc/library/ipaddress.rst
26c2e37 
Co-authored-by: Hugo van Kemenade <[email protected]>
gpshead
gpshead approved these changes Nov 5, 2023
View reviewed changes

@gpshead gpshead left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Nov 5, 2023
@gpshead gpshead self-assigned this Nov 5, 2023
@gpshead gpshead added the type-feature A feature request or enhancement label Nov 5, 2023
@gpshead
Merge branch 'main' into ipv6_mapped
03c5d04
@gpshead
gpshead enabled auto-merge (squash) November 5, 2023 16:23
@gpshead gpshead changed the title gh-109466: Add ipv6_mapped property to IPV4Address gh-109466: Add ipv6_mapped property to IPv4Address Nov 5, 2023
@gpshead
gpshead merged commit ba8aa1f into python:main Nov 5, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 5, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@csm10495 @hugovk @aisk
pythongh-109466: Add ipv6_mapped property to IPv4Address (python#109467)
1bfd3f3 
Adds the `IPv4Address.ipv6_mapped` property.

Co-authored-by: Hugo van Kemenade <[email protected]>
@jstasiak

jstasiak commented May 30, 2024

Copy link
Copy Markdown
Contributor

Cross-referencing #119814 for visibility.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@csm10495 @hugovk @Glyphack
pythongh-109466: Add ipv6_mapped property to IPv4Address (python#109467)
0559321 
Adds the `IPv4Address.ipv6_mapped` property.

Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments
@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add ipv6_mapped property to IPv4Address

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@csm10495 @jstasiak @gpshead @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.