GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Fix error handling in _PySys_UpdateConfig() by serhiy-storchaka · Pull Request #109524 · python/cpython

Conversation

serhiy-storchaka commented Sep 17, 2023

Copy link

Copy Markdown

Member

_PySys_GetObject() can return NULL without setting an error.
Error in PyDict_SetItemString() was not handled.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Fix error handling in _PySys_UpdateConfig()

d3c0006

serhiy-storchaka added type-bug

An unexpected behavior, bug, or error

needs backport to 3.11

only security fixes

needs backport to 3.12 only security fixes labels

Sep 17, 2023

serhiy-storchaka requested a review from ericsnowcurrently

September 17, 2023 19:11

bedevere-app Bot added the awaiting review label

Sep 17, 2023

serhiy-storchaka added skip issue skip news labels

Sep 17, 2023

ericsnowcurrently approved these changes

Sep 18, 2023

View reviewed changes

ericsnowcurrently left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting core review and removed awaiting review labels

Sep 18, 2023

ericsnowcurrently commented Sep 18, 2023

Copy link

Copy Markdown

Member

Thanks for catching this and for the fix!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka merged commit c829975 into python:main

Sep 18, 2023

miss-islington commented Sep 18, 2023

Copy link

Copy Markdown

Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting core review label

Sep 18, 2023

serhiy-storchaka deleted the _PySys_UpdateConfig-errors branch

September 18, 2023 17:10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 18, 2023


          Fix error handling in _PySys_UpdateConfig() (pythonGH-109524)

5adce41

(cherry picked from commit c829975)

Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-app Bot commented Sep 18, 2023

Copy link

Copy Markdown

GH-109550 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label

Sep 18, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 18, 2023


          Fix error handling in _PySys_UpdateConfig() (pythonGH-109524)

9e8e018

(cherry picked from commit c829975)

Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-app Bot commented Sep 18, 2023

Copy link

Copy Markdown

GH-109551 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label

Sep 18, 2023

serhiy-storchaka added a commit that referenced this pull request

Sep 18, 2023


          [3.11] Fix error handling in _PySys_UpdateConfig() (GH-109524) (GH-10…

17a335d

…9551)

(cherry picked from commit c829975)

Co-authored-by: Serhiy Storchaka <[email protected]>

csm10495 pushed a commit to csm10495/cpython that referenced this pull request

Sep 28, 2023


          Fix error handling in _PySys_UpdateConfig() (pythonGH-109524)

6d6ceb9

Yhg1s pushed a commit that referenced this pull request

Oct 2, 2023


          [3.12] Fix error handling in _PySys_UpdateConfig() (GH-109524) (#109550)

df2cdcf

Fix error handling in _PySys_UpdateConfig() (GH-109524)
(cherry picked from commit c829975)

Co-authored-by: Serhiy Storchaka <[email protected]>

Reviewers

ericsnowcurrently

ericsnowcurrently approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news type-bug

An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.