GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-109125: Run mypy on `Tools/wasm` (GH-109126) by hugovk · Pull Request #109561 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Sep 19, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit f65497f)

Includes the other missing ones.

  • Issue: Run mypy on Tools/wasm #109125

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn @hugovk
[3.12] pythongh-109125: Run mypy on Tools/wasm (pythonGH-109126)
539da8e 
(cherry picked from commit f65497f)

Co-authored-by: Nikita Sobolev <[email protected]>
@hugovk
hugovk requested a review from ezio-melotti as a code owner September 19, 2023 05:59
@bedevere-app bedevere-app Bot added the awaiting review label Sep 19, 2023
This was referenced Sep 19, 2023
Run mypy on Tools/wasm #109125
Closed
gh-109125: Run mypy on Tools/wasm #109126
Merged
@bedevere-app bedevere-app Bot added the skip news label Sep 19, 2023
corona10
corona10 reviewed Sep 19, 2023
View reviewed changes
Comment thread .github/workflows/mypy.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
corona10
corona10 reviewed Sep 19, 2023
View reviewed changes
Comment thread .github/workflows/mypy.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk marked this pull request as draft September 19, 2023 07:16
@bedevere-app bedevere-app Bot removed the awaiting review label Sep 19, 2023
@hugovk
Only backport mypy for Tools/wasm
3c0f0f0
@hugovk

hugovk commented Sep 19, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

I've updated the PR only to backport the Tools/wasm checking, but on second thoughts, let's close this and we can add it later if anyone wants it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk closed this Sep 19, 2023
@hugovk
hugovk deleted the backport-f65497f-3.12 branch September 25, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 left review comments
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hugovk @corona10 @sobolevn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.