Description

sobolevn

opened on Sep 8, 2023

Issue body actions

Feature or enhancement

Right now we already have 3 fully typed and checked tools:

• Add type annotations to clinic.py #104050
• Run mypy on Tools/peg_generator #108455
• Run mypy on cases_generator #104504

I think we can also add Tools/wasm quite easily to this list.
Tools/wasm already has most of the type annotations, but there are some mypy errors to fix.

Linked PRs

• gh-109125: Run mypy on Tools/wasm #109126
• [3.12] gh-109125: Run mypy on Tools/wasm (GH-109126) #109561

Activity

1. sobolevn

   added

   type-featureA feature request or enhancementA feature request or enhancement

   topic-typing

   OS-wasi

   on Sep 8, 2023
2. sobolevn

   self-assigned this

   on Sep 8, 2023
3. sobolevn

   added a commit that references this issue on Sep 8, 2023

   pythongh-109125: Run mypy on `Tools/wasm`

   00ecd77
4. brettcannon commented on Sep 8, 2023

   

   brettcannon

   on Sep 8, 2023

   Member

   More actions

   I'm not sure if it's worth keeping a couple of scripts typed, especially based on the restrictions of typing in the repo (e.g., older versions of Python w/o typing_extensions access, etc.). I honestly would be fine stripping out the types in the scripts in that directory rather than try to keep the types working.

   Reacted by Donghee Na and chirk
5. corona10 commented on Sep 10, 2023

   

   corona10

   on Sep 10, 2023

   Member

   More actions

   We may need to define the scope of what scripts would be worth adding typing, and applying mypy pipeline.

   cc @AlexWaygood @erlend-aasland @vstinner
6. AlexWaygood commented on Sep 10, 2023

   

   AlexWaygood

   on Sep 10, 2023

   Member

   More actions

   We may need to define the scope of what scripts would be worth adding typing, and applying mypy pipeline.

   I'm not sure this needs to be formalised much. I think we should add mypy to CI for self-contained CPython projects where the maintainers of those projects say they'd find it useful. We should avoid doing so for projects where the maintainers of those projects say it wouldn't be useful.

   Reacted by Jelle Zijlstra, Erlend E. Aasland and chirk
7. vstinner commented on Sep 10, 2023

   

   vstinner

   on Sep 10, 2023

   Member

   More actions

   Once I will be done with refactoring libregrtest #109162 I will need help to add type hints there ;-) IMO it would be a more interesting target than Tools/wasm/ scripts.
8. hugovk

   added 2 commits that reference this issue on Sep 19, 2023

   gh-109125: Run mypy on `Tools/wasm` (#109126)

   f65497f

   [3.12] pythongh-109125: Run mypy on `Tools/wasm` (pythonGH-109126)

   539da8e
9. hugovk commented on Sep 19, 2023

   

   hugovk

   on Sep 19, 2023

   Member

   More actions

   Done via #109126, thanks!
10. hugovk

    closed this as completedon Sep 19, 2023
11. csm10495

    added a commit that references this issue on Sep 28, 2023

    pythongh-109125: Run mypy on `Tools/wasm` (python#109126)

    c0a0a8a

Issue actions