GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109566: Run buildbot tests with --fail-rerun by vstinner · Pull Request #109567 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 19, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Unify ways to run the Python test suite #109566

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-109566: Run buildbot tests with --fail-rerun
8dd5a56
@vstinner vstinner added the skip news label Sep 19, 2023
@bedevere-app bedevere-app Bot added the awaiting review label Sep 19, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 19, 2023
Unify ways to run the Python test suite #109566
Closed
@vstinner

vstinner commented Sep 19, 2023

Copy link
Copy Markdown
Member Author

Since tests are now re-run in fresh processes, it's more likely that they pass when being re-run in verbose mode.

IMO we should make tests fail if a test failed and then succeeded when re-run: we should not silence tests failing randomly.

See also: https://discuss.python.org/t/consider-downgrading-windows-32-bit-from-tier-1-to-tier-2-or-tier-3-in-python-3-13/33719/37
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
Move --fail options from test.bat to rt.bat
fe69a52
@vstinner
vstinner requested a review from a team as a code owner September 19, 2023 11:46
@vstinner

vstinner commented Sep 19, 2023

Copy link
Copy Markdown
Member Author

Hum, the two GHA Windows jobs run directly PCbuild\rt.bat, instead of Tools\buildbot\test.bat. I moved the two --fail options in rt.bat, so the GHA Windows jobs use them.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 67d9363 into python:main Sep 19, 2023
@vstinner
vstinner deleted the buildbot_fail_rerun branch September 19, 2023 13:50
@bedevere-app bedevere-app Bot removed the awaiting review label Sep 19, 2023
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@vstinner @csm10495
pythongh-109566: Run GHA and buildbot tests with --fail-rerun (python…
9e4d048 
…#109567)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.