GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-108724: Fix _PySemaphore compile error on WASM by colesbury · Pull Request #109583 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Sep 19, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Some WASM platforms have POSIX semaphores, but not sem_timedwait.

  • Issue: Add lightweight locking C API #108724

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury
pythongh-108724: Fix _PySemaphore compile error on WASM
a9c0a5b 
Some WASM platforms have POSIX semaphores, but not sem_timedwait.
@colesbury colesbury added the skip news label Sep 19, 2023
@colesbury
colesbury requested a review from ericsnowcurrently September 19, 2023 17:06
@bedevere-app bedevere-app Bot added the awaiting review label Sep 19, 2023
@colesbury colesbury added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 19, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 19, 2023
Add lightweight locking C API #108724
Closed
@bedevere-bot

bedevere-bot commented Sep 19, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit a9c0a5b 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 19, 2023
ericsnowcurrently
ericsnowcurrently approved these changes Sep 19, 2023
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 19, 2023
@ericsnowcurrently

ericsnowcurrently commented Sep 19, 2023

Copy link
Copy Markdown
Member

The build step succeeded for "buildbot/wasm32-emscripten node (dynamic linking) PR", so I'm calling this good. :)
colesbury reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently
ericsnowcurrently enabled auto-merge (squash) September 19, 2023 17:22
@ericsnowcurrently ericsnowcurrently mentioned this pull request Sep 19, 2023
gh-108724: Add PyMutex and _PyParkingLot APIs #109344
Merged
@ericsnowcurrently
ericsnowcurrently merged commit 9df6712 into python:main Sep 19, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 19, 2023
@colesbury
colesbury deleted the pymutex-fix-wasm branch September 19, 2023 21:00
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@colesbury @csm10495
pythongh-108724: Fix _PySemaphore compile error on WASM (pythongh-109583
cd452fb 
)

Some WASM platforms have POSIX semaphores, but not sem_timedwait.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@colesbury @bedevere-bot @ericsnowcurrently
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.