GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104469: Convert _testcapi/vectorcall_limited.c to use AC by vstinner · Pull Request #109691 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 21, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Improve the readability and maintainability of test_capi using the AC #104469

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner @nahyeon-an
pythongh-104469: Convert _testcapi/vectorcall_limited.c to use AC
8004d79 
Co-Authored-By: nahyeon <[email protected]>
@bedevere-app bedevere-app Bot added the awaiting review label Sep 21, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 21, 2023
Improve the readability and maintainability of test_capi using the AC #104469
Closed
@vstinner vstinner mentioned this pull request Sep 21, 2023
gh-104469 : Convert _testcapi/vectorcall_limited.c to use AC #107857
Merged
@vstinner

vstinner commented Sep 21, 2023

Copy link
Copy Markdown
Member Author

cc @corona10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner added the skip news label Sep 21, 2023
@vstinner

vstinner commented Sep 22, 2023

Copy link
Copy Markdown
Member Author

cc @erlend-aasland
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
Merge branch 'main' into testcapi_vectorcall_limited
9c2841b
vstinner
vstinner commented Sep 25, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before and after, the two functions use METH_O calling convention. Nothing crazy, there is no generated code to parse arguments, since the only argument is declared as callable: object in both cases.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
vstinner merged commit 8c521f0 into python:main Sep 25, 2023
@vstinner
vstinner deleted the testcapi_vectorcall_limited branch September 25, 2023 11:24
@bedevere-app bedevere-app Bot removed the awaiting review label Sep 25, 2023
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@vstinner @nahyeon-an @csm10495
pythongh-104469: Convert _testcapi/vectorcall_limited.c to use AC (py…
4ede466 
…thon#109691)

Co-authored-by: nahyeon <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @nahyeon-an @Glyphack
pythongh-104469: Convert _testcapi/vectorcall_limited.c to use AC (py…
062b6c5 
…thon#109691)

Co-authored-by: nahyeon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.