GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-108388: Convert test_concurrent_futures to package (#108401) by vstinner · Pull Request #109704 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 22, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Split long running test suites up into smaller sub suites to reduce our regrtest long tail on multi-core systems. #108388

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
vstinner added 2 commits September 22, 2023 02:43
@vstinner
pythongh-108388: Convert test_concurrent_futures to package (python#1…
b3574d8 
…08401)

Convert test_concurrent_futures to a package of sub-tests.

(cherry picked from commit aa6f787)
@vstinner
Fix the backport
0b7d750 
* AsCompletedTests: Revert test_future_times_out() => test_zero_timeout()
* Restore TODO comment
* ThreadPoolExecutorTest.test_hang_global_shutdown_lock():
  add @support.requires_resource('cpu').
@bedevere-app bedevere-app Bot added the awaiting review label Sep 22, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 21, 2023
Split long running test suites up into smaller sub suites to reduce our regrtest long tail on multi-core systems. #108388
Closed
@bedevere-app bedevere-app Bot added the skip news label Sep 22, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 22, 2023
gh-108388: Convert test_concurrent_futures to package #108401
Merged
@vstinner

vstinner commented Sep 22, 2023

Copy link
Copy Markdown
Member Author

Backporting PR #108401 to 3.11 branch was challenging.

I used git cherry-pick -x, fixed conflicts, and then I "undone" manually the change by moving code again into as single Lib/test/test_concurrent_futures.py to compare changes, and I compared code before/after using meld.

I found a few minor differences, the second commit of this PR:

  • AsCompletedTests: Revert test_future_times_out() => test_zero_timeout()
  • Restore TODO comment
  • ThreadPoolExecutorTest.test_hang_global_shutdown_lock(): add @support.requires_resource('cpu').

I also compared the new test_concurrent_futures/ directory in 3.11 and main branches. There are only minor differences. Some minor changes no backported to 3.11.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Sep 22, 2023

Copy link
Copy Markdown
Member Author

Once this change is merged, I will be able to backport #109703 to 3.11.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner enabled auto-merge (squash) September 22, 2023 01:14
@vstinner
vstinner merged commit 66a973a into python:3.11 Sep 22, 2023
@vstinner
vstinner deleted the test_concurrent_package311 branch September 22, 2023 01:37
@bedevere-app bedevere-app Bot removed the awaiting review label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.