GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109706: Fix multiprocessing test_nested_startmethod() by vstinner · Pull Request #109707 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 22, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Don't check order, queue items can be written in any order.

  • Issue: test_multiprocessing_fork: test_nested_startmethod() fails randomly. #109706

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner
pythongh-109706: Fix multiprocessing test_nested_startmethod()
06aa63b
Don't check order, queue items can be written in any order.
@vstinner vstinner added tests Tests in the Lib/test dir needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 22, 2023
@bedevere-app bedevere-app Bot added the awaiting review label Sep 22, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 22, 2023
test_multiprocessing_fork: test_nested_startmethod() fails randomly. #109706
Closed
@vstinner vstinner mentioned this pull request Sep 22, 2023
gh-108520: Fix bad fork detection in nested multiprocessing use case #108568
Merged
@vstinner vstinner added the skip news label Sep 22, 2023
@vstinner

vstinner commented Sep 22, 2023

Copy link
Copy Markdown
Member Author

cc @pitrou

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pitrou
pitrou approved these changes Sep 22, 2023
View reviewed changes

@pitrou pitrou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. This behavior is arguably non-intuitive...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 22, 2023
@vstinner

vstinner commented Sep 22, 2023

Copy link
Copy Markdown
Member Author

LGTM, thanks. This behavior is arguably non-intuitive...

Well... I'm no longer surprised by surprising multiprocessing behavior :-D

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner merged commit b03a791 into python:main Sep 22, 2023
@vstinner
vstinner deleted the test_nested_startmethod branch September 22, 2023 21:49
@miss-islington

miss-islington commented Sep 22, 2023

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 22, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 22, 2023
@vstinner @miss-islington
pythongh-109706: Fix multiprocessing test_nested_startmethod() (pytho…
a83132f
…nGH-109707)

Don't check order, queue items can be written in any order.
(cherry picked from commit b03a791)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 22, 2023

Copy link
Copy Markdown

GH-109762 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 22, 2023
@vstinner @miss-islington
pythongh-109706: Fix multiprocessing test_nested_startmethod() (pytho…
9b81414
…nGH-109707)

Don't check order, queue items can be written in any order.
(cherry picked from commit b03a791)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 22, 2023
@bedevere-app

bedevere-app Bot commented Sep 22, 2023

Copy link
Copy Markdown

GH-109763 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Sep 22, 2023
@vstinner

vstinner commented Sep 22, 2023

Copy link
Copy Markdown
Member Author

Merged. Thanks for the review @pitrou. I wasn't sure about that one!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner added a commit that referenced this pull request Sep 22, 2023
@miss-islington @vstinner
[3.11] gh-109706: Fix multiprocessing test_nested_startmethod() (GH-1…
3db2ec2
…09707) (#109763)

gh-109706: Fix multiprocessing test_nested_startmethod() (GH-109707)

Don't check order, queue items can be written in any order.
(cherry picked from commit b03a791)

Co-authored-by: Victor Stinner <[email protected]>
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@vstinner @csm10495
pythongh-109706: Fix multiprocessing test_nested_startmethod() (pytho…
0066283
…n#109707)

Don't check order, queue items can be written in any order.
Yhg1s pushed a commit that referenced this pull request Oct 2, 2023
@miss-islington @vstinner
[3.12] gh-109706: Fix multiprocessing test_nested_startmethod() (GH-1…
6a6bea3
…09707) (#109762)

gh-109706: Fix multiprocessing test_nested_startmethod() (GH-109707)

Don't check order, queue items can be written in any order.
(cherry picked from commit b03a791)

Co-authored-by: Victor Stinner <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @Glyphack
pythongh-109706: Fix multiprocessing test_nested_startmethod() (pytho…
ba451d2
…n#109707)

Don't check order, queue items can be written in any order.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @miss-islington @pitrou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.