GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ACKS: Fix ordering; Correct Itamar Oren's surname; Add Adam Turner by AA-Turner · Pull Request #109737 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Sep 22, 2023

Copy link
Copy Markdown
Member

cc: @itamaro

Following on from #109661, hope you don't mind me opening the PR!

A

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
ACKS: Correct Itamar Oren's surname
21cb483
@bedevere-app bedevere-app Bot added the awaiting review label Sep 22, 2023
@AA-Turner AA-Turner added docs Documentation in the Doc dir skip issue skip news labels Sep 22, 2023
@hugovk

hugovk commented Sep 22, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

As we're editing this, the last two names were tacked on the end, instead of being in "rough alphabetical order by last names". (But not the name beginning Å, that comes after Z.)

Would you like to slot them back into place?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner added 2 commits September 22, 2023 14:59
@AA-Turner
ACKS: Fix ordering
5207565
@AA-Turner
ACKS: Add Adam Turner
29b253e
@AA-Turner

AA-Turner commented Sep 22, 2023

Copy link
Copy Markdown
Member Author

Doroschenko is already present in the right order, it seems! I also took the liberty of adding myself, if that's alright?

A
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner AA-Turner changed the title ACKS: Correct Itamar Oren's surname ACKS: Fix ordering; Correct Itamar Oren's surname; Add Adam Turner Sep 22, 2023
hugovk
hugovk approved these changes Sep 22, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 22, 2023
itamaro
itamaro approved these changes Sep 22, 2023
View reviewed changes

@itamaro itamaro left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner AA-Turner added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 22, 2023
carljm
carljm approved these changes Sep 22, 2023
View reviewed changes
ambv
ambv reviewed Sep 22, 2023
View reviewed changes
Comment thread Misc/ACKS Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ambv
ambv merged commit 3e8fcb7 into python:main Sep 22, 2023
@miss-islington

miss-islington commented Sep 22, 2023

Copy link
Copy Markdown
Contributor

Thanks @AA-Turner for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 22, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 22, 2023
@AA-Turner @miss-islington
ACKS: Fix ordering; Correct Itamar Oren's surname; Add Adam Turner (p…
2f6939b 
…ythonGH-109737)

(cherry picked from commit 3e8fcb7)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 22, 2023

Copy link
Copy Markdown

GH-109741 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 22, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 22, 2023
@AA-Turner @miss-islington
ACKS: Fix ordering; Correct Itamar Oren's surname; Add Adam Turner (p…
6a5cca6 
…ythonGH-109737)

(cherry picked from commit 3e8fcb7)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 22, 2023

Copy link
Copy Markdown

GH-109742 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Sep 22, 2023
AlexWaygood pushed a commit that referenced this pull request Sep 22, 2023
@miss-islington @AA-Turner
[3.11] ACKS: Fix ordering; Correct Itamar Oren's surname; Add Adam Tu…
567c3e8 
…rner (GH-109737) (#109742)

ACKS: Fix ordering; Correct Itamar Oren's surname; Add Adam Turner  (GH-109737)
(cherry picked from commit 3e8fcb7)

Co-authored-by: Adam Turner <[email protected]>
ambv pushed a commit that referenced this pull request Sep 22, 2023
@miss-islington @AA-Turner
[3.12] ACKS: Fix ordering; Correct Itamar Oren's surname; Add Adam Tu…
f6287bd 
…rner (GH-109737) (#109741)

(cherry picked from commit 3e8fcb7)

Co-authored-by: Adam Turner <[email protected]>
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@AA-Turner @csm10495
ACKS: Fix ordering; Correct Itamar Oren's surname; Add Adam Turner (p…
ff9ecae 
…ython#109737)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@AA-Turner @Glyphack
ACKS: Fix ordering; Correct Itamar Oren's surname; Add Adam Turner (p…
f22c33a 
…ython#109737)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv left review comments
@carljm carljm carljm approved these changes
@itamaro itamaro itamaro approved these changes
@hugovk hugovk hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@AA-Turner @hugovk @miss-islington @ambv @carljm @itamaro
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.