GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-109190: Copyedit 3.12 What's New: Update the ``imp`` porting guidance by AA-Turner · Pull Request #109755 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Sep 22, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • This merges three bullets into one, and rewords the lead to make it clear that this is a guide to porting rather than an internal change to Python.
  • Issue: What's New in Python 3.12 (copyediting) #109190

📚 Documentation preview 📚: https://cpython-previews--109755.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
Merge the imp porting bullets; re-word the intro
675f5fa
@AA-Turner AA-Turner added the needs backport to 3.12 only security fixes label Sep 22, 2023
@AA-Turner
AA-Turner requested review from ambv, hugovk and vstinner September 22, 2023 18:49
@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Sep 22, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 22, 2023
What's New in Python 3.12 (copyediting) #109190
Closed
@hugovk

hugovk commented Sep 22, 2023

Copy link
Copy Markdown
Member

There's also a "Porting to Python 3.12" section further down the page, should some of this be moved there, with a link to it?

Similar to how "tokenize" does it?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner

AA-Turner commented Sep 22, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

I wasn't sure on moving to Porting so opted for the less invasive change initially. I'd agree it makes sense (& we can include a cross-ref from 'Removed'), cc @vstinner for thoughts as the author of #105905 (#104212).

A
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Sep 24, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 24, 2023
hugovk
hugovk approved these changes Sep 25, 2023
View reviewed changes
@hugovk
hugovk merged commit 7b8bfe1 into python:main Sep 25, 2023
@miss-islington

miss-islington commented Sep 25, 2023

Copy link
Copy Markdown
Contributor

Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 25, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 25, 2023
@AA-Turner @miss-islington
pythonGH-109190: Copyedit 3.12 What's New: Update the imp porting…
f1b4d30 
… guidance (pythonGH-109755)

(cherry picked from commit 7b8bfe1)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 25, 2023

Copy link
Copy Markdown

GH-109816 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 25, 2023
Yhg1s pushed a commit that referenced this pull request Sep 25, 2023
@miss-islington @AA-Turner
[3.12] GH-109190: Copyedit 3.12 What's New: Update the imp portin…
52b2f9f 
…g guidance (GH-109755) (#109816)

GH-109190: Copyedit 3.12 What's New: Update the ``imp`` porting guidance (GH-109755)
(cherry picked from commit 7b8bfe1)

Co-authored-by: Adam Turner <[email protected]>
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@AA-Turner @csm10495
pythonGH-109190: Copyedit 3.12 What's New: Update the imp porting…
58ed026 
… guidance (python#109755)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@AA-Turner @Glyphack
pythonGH-109190: Copyedit 3.12 What's New: Update the imp porting…
1ad7ef4 
… guidance (python#109755)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@hugovk hugovk hugovk approved these changes
@ambv ambv Awaiting requested review from ambv

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@AA-Turner @hugovk @miss-islington @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.