GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109653: Remove unused imports in the `Lib/` directory by AlexWaygood · Pull Request #109803 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Sep 24, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

As suggested in #109653 (comment) by @hugovk.

Nearly all of these are in Lib/test/, but there is also one in Lib/asyncio/tasks.py.

  • Issue: Improve import time of various stdlib modules #109653

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
AlexWaygood added 2 commits September 23, 2023 16:08
@AlexWaygood
Remove unused imports in the Lib/ directory
e62f238
@AlexWaygood
two more
82d73a0
@AlexWaygood AlexWaygood added the skip news label Sep 24, 2023
@AlexWaygood
AlexWaygood requested review from 1st1, asvetlov, berkerpeksag, brettcannon, cjw296, ericsnowcurrently, erlend-aasland, gvanrossum, kumaraditya303, lysnikolaou, ncoghlan, pablogsal, rhettinger, warsaw and willingc as code owners September 24, 2023 12:13
@bedevere-app bedevere-app Bot added the awaiting review label Sep 24, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 24, 2023
Improve import time of various stdlib modules #109653
Closed
@AlexWaygood
revert changes to test_monitoring
61a1a35
erlend-aasland
erlend-aasland approved these changes Sep 24, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 24, 2023
@AlexWaygood
AlexWaygood merged commit 19601ef into python:main Sep 24, 2023
@AlexWaygood
AlexWaygood deleted the unused-imports branch September 24, 2023 14:07
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 24, 2023
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@AlexWaygood @csm10495
pythongh-109653: Remove unused imports in the Lib/ directory (pytho…
1b27fe3 
…n#109803)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@AlexWaygood @Glyphack
pythongh-109653: Remove unused imports in the Lib/ directory (pytho…
4638f8f 
…n#109803)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag
@cjw296 cjw296 Awaiting requested review from cjw296 cjw296 is a code owner
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@AlexWaygood @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.