GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109653: Avoid a top-level import of `types` in `functools` by AlexWaygood · Pull Request #109804 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Sep 24, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reduces the import time of functools by around 13%, according to my measurements (using a PGO-optimised non-debug build, on Windows)

  • Issue: Improve import time of various stdlib modules #109653

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood
pythongh-109653: Avoid a top-level import of types in functools
46cf001
@AlexWaygood
AlexWaygood requested a review from rhettinger as a code owner September 24, 2023 12:29
@bedevere-app bedevere-app Bot added the awaiting review label Sep 24, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 24, 2023
Improve import time of various stdlib modules #109653
Closed
rhettinger
rhettinger approved these changes Sep 24, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 24, 2023
@AlexWaygood
AlexWaygood merged commit 40d1de7 into python:main Sep 24, 2023
@AlexWaygood
AlexWaygood deleted the functools-import-time branch September 24, 2023 16:18
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 24, 2023
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@AlexWaygood @csm10495
pythongh-109653: Avoid a top-level import of types in functools (p…
bb9da70 
…ython#109804)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@AlexWaygood @Glyphack
pythongh-109653: Avoid a top-level import of types in functools (p…
f8e689e 
…ython#109804)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger rhettinger approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@AlexWaygood @rhettinger
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.