GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] GH-109190: Copyedit 3.12 What's New: Improve the C-API deprecations section (GH-109751) by miss-islington · Pull Request #109830 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 25, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit bccc1b7)

Co-authored-by: Adam Turner [email protected]
Co-authored-by: Serhiy Storchaka [email protected]

  • Issue: What's New in Python 3.12 (copyediting) #109190

📚 Documentation preview 📚: https://cpython-previews--109830.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@AA-Turner @serhiy-storchaka @miss-islington
pythonGH-109190: Copyedit 3.12 What's New: Improve the C-API deprecat…
ee25e38
…ions section (pythonGH-109751)

(cherry picked from commit bccc1b7)

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Sep 25, 2023
This was referenced Sep 25, 2023
What's New in Python 3.12 (copyediting) #109190
Closed
GH-109190: Copyedit 3.12 What's New: Improve the C-API deprecations section #109751
Merged
AA-Turner
AA-Turner approved these changes Sep 25, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 25, 2023
@AA-Turner AA-Turner assigned Yhg1s Sep 25, 2023
hugovk
hugovk approved these changes Sep 25, 2023
View reviewed changes
@hugovk

hugovk commented Sep 25, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@AA-Turner We're getting a CI failure on this one:

Emitting doc warnings matching modified lines:
Warning: c:func reference target not found: PyWeakref_GetRef
/home/runner/work/cpython/cpython/Doc/whatsnew/3.12.rst:2176: WARNING: c:func reference target not found: PyWeakref_GetRef
Warning: c:func reference target not found: PyWeakref_GetRef
/home/runner/work/cpython/cpython/Doc/whatsnew/3.12.rst:2177: WARNING: c:func reference target not found: PyWeakref_GetRef

Error: must not contain warnings:

Doc/whatsnew/3.12.rst
  2176: c:func reference target not found: PyWeakref_GetRef
  2177: c:func reference target not found: PyWeakref_GetRef
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AA-Turner

AA-Turner commented Sep 25, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Oh, looks like one of the 3.13 deprecations slipped through. I'll push to this PR & open a new one.

Edit: What's actually happened is that I listed all the functions pending removal in Python 3.15 in an attempt to give C developers more notice, but several of these aren't deprecated in Python 3.12. I've removed the two offending lines here as the replacement function was only added in Python 3.13, so I don't think there's benefit to listing them in the 3.12 What's New given nothing can be done by programmers to port their usages.

A

hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AA-Turner
Remove the weakref get object functions
4fb1d03
@hugovk

hugovk commented Sep 25, 2023

Copy link
Copy Markdown
Member

Thanks, let's also update Doc/whatsnew/3.12.rst in main to match.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AA-Turner AA-Turner mentioned this pull request Sep 25, 2023
GH-109190: Copyedit 3.12 What's New: Synchronise C API deprecations with the 3.12 branch #109844
Merged
@Yhg1s
Yhg1s merged commit a192517 into python:3.12 Sep 26, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 26, 2023
@miss-islington
miss-islington deleted the backport-bccc1b7-3.12 branch September 26, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@AA-Turner AA-Turner AA-Turner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Yhg1s Yhg1s

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @hugovk @AA-Turner @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.