GeezerVison is showing github.com — [3.12] GH-109190: Copyedit 3.12 What's New: Improve the C-API deprecations section (GH-109751) by miss-islington · Pull Request #109830 · python/cpython
Conversation
miss-islington
commented
Sep 25, 2023
•
edited by github-actions
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Sep 25, 2023
hugovk
commented
Sep 25, 2023
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
@AA-Turner We're getting a CI failure on this one:
Emitting doc warnings matching modified lines:
Warning: c:func reference target not found: PyWeakref_GetRef
/home/runner/work/cpython/cpython/Doc/whatsnew/3.12.rst:2176: WARNING: c:func reference target not found: PyWeakref_GetRef
Warning: c:func reference target not found: PyWeakref_GetRef
/home/runner/work/cpython/cpython/Doc/whatsnew/3.12.rst:2177: WARNING: c:func reference target not found: PyWeakref_GetRef
Error: must not contain warnings:
Doc/whatsnew/3.12.rst
2176: c:func reference target not found: PyWeakref_GetRef
2177: c:func reference target not found: PyWeakref_GetRef
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
AA-Turner
commented
Sep 25, 2023
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
Oh, looks like one of the 3.13 deprecations slipped through. I'll push to this PR & open a new one.
Edit: What's actually happened is that I listed all the functions pending removal in Python 3.15 in an attempt to give C developers more notice, but several of these aren't deprecated in Python 3.12. I've removed the two offending lines here as the replacement function was only added in Python 3.13, so I don't think there's benefit to listing them in the 3.12 What's New given nothing can be done by programmers to port their usages.
A
|
hugovk reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Thanks, let's also update Doc/whatsnew/3.12.rst in main to match.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
hugovk
hugovk approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.