GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-109190: Copyedit 3.12 What's New: Improve the C-API deprecations section by AA-Turner · Pull Request #109751 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Sep 22, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Per @vstinner's note, move deprecations of ma_version_tag and immutable types / mutable bases to the C-API section
  • Introduce Pending Removal in Python 3.14 / Python 3.15 / Future Versions sections
  • Copy the list of deprecations from 3.13 What's New to these sections (with minor copyediting)
  • Issue: What's New in Python 3.12 (copyediting) #109190

📚 Documentation preview 📚: https://cpython-previews--109751.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
AA-Turner added 6 commits September 22, 2023 18:24
@AA-Turner
Move C-API deprecations to the C-API section
02824ae
@AA-Turner
Copy the 3.13 "Pending Removal in Future Versions" list
f9a6a95
@AA-Turner
Note that the global config variables will be removed in 3.14
5d87553
@AA-Turner
Copy the 3.13 "Pending Removal in Python 3.15" list
1653e42
@AA-Turner
Note pending removal of PyErr_Display
ac8849c
@AA-Turner
Suggest alternative for _PyErr_ChainExceptions
4502df2
@AA-Turner AA-Turner added the needs backport to 3.12 only security fixes label Sep 22, 2023
@AA-Turner
AA-Turner requested review from ambv, hugovk, serhiy-storchaka and vstinner September 22, 2023 17:45
@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Sep 22, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 22, 2023
What's New in Python 3.12 (copyediting) #109190
Closed
AA-Turner
AA-Turner commented Sep 22, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst
Comment on lines -1258 to -1259
* Creating :c:data:`immutable types <Py_TPFLAGS_IMMUTABLETYPE>` with mutable
bases using the C API (:gh:`95388`)

@AA-Turner AA-Turner Sep 22, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note this entry was duplicated; I've only kept one of them

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
Fix rebase error (restore position; use nicer markup)
a9241e2
@AA-Turner AA-Turner changed the title GH-109190: Move C-API deprecations to the C-API section GH-109190: Copyedit 3.12 What's New: Improve the C-API deprecations section Sep 22, 2023
vstinner
vstinner approved these changes Sep 24, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks for going through all deprecated C API! I didn't realize that this list was so long!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 24, 2023
serhiy-storchaka
serhiy-storchaka reviewed Sep 25, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner @serhiy-storchaka
Suggest more replacement functions
7312d08 
Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
serhiy-storchaka approved these changes Sep 25, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst
* :c:func:`!PyUnicode_AsEncodedUnicode`: use c:func:`PyCodec_Encode`
* :c:func:`PyUnicode_READY`: unneeded since Python 3.12
* :c:func:`!PyErr_Display`: use :c:func:`PyErr_DisplayException`
* :c:func:`!_PyErr_ChainExceptions`: use ``_PyErr_ChainExceptions1``

@serhiy-storchaka serhiy-storchaka Sep 25, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this. It is an internal convenient function, and it can be removed or changed in incompatible way without warning.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@AA-Turner AA-Turner Sep 25, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're recommending a private replacement to a private function here, so I think it's fine. This isn't saying that readers should use the functions, just what the replacements for the deprecated versions are.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
hugovk
hugovk reviewed Sep 25, 2023
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
syntax
2420937
hugovk
hugovk approved these changes Sep 25, 2023
View reviewed changes
@hugovk
hugovk enabled auto-merge (squash) September 25, 2023 12:34
@hugovk
hugovk merged commit bccc1b7 into python:main Sep 25, 2023
@miss-islington

miss-islington commented Sep 25, 2023

Copy link
Copy Markdown
Contributor

Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 25, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 25, 2023
@AA-Turner @serhiy-storchaka @miss-islington
pythonGH-109190: Copyedit 3.12 What's New: Improve the C-API deprecat…
ee25e38 
…ions section (pythonGH-109751)

(cherry picked from commit bccc1b7)

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 25, 2023

Copy link
Copy Markdown

GH-109830 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 25, 2023
@vstinner

vstinner commented Sep 25, 2023

Copy link
Copy Markdown
Member

Would you mind to copy the "Pending Removal xxx" sections of C API Changes to What's New In Python 3.13? (main branch)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner

AA-Turner commented Sep 25, 2023

Copy link
Copy Markdown
Member Author

Done: #109843

A
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Yhg1s pushed a commit that referenced this pull request Sep 26, 2023
@miss-islington @AA-Turner @serhiy-storchaka
[3.12] GH-109190: Copyedit 3.12 What's New: Improve the C-API depreca…
a192517 
…tions section (GH-109751) (#109830)

* GH-109190: Copyedit 3.12 What's New: Improve the C-API deprecations section (GH-109751)
(cherry picked from commit bccc1b7)

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>

* Remove the weakref get object functions

---------

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@AA-Turner @serhiy-storchaka @csm10495
pythonGH-109190: Copyedit 3.12 What's New: Improve the C-API deprecat…
a663082 
…ions section (python#109751)

Co-authored-by: Serhiy Storchaka <[email protected]>
@AA-Turner
AA-Turner deleted the docs/whatsnew/c-api branch September 29, 2023 08:16
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@AA-Turner @serhiy-storchaka @Glyphack
pythonGH-109190: Copyedit 3.12 What's New: Improve the C-API deprecat…
41d58be 
…ions section (python#109751)

Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@hugovk hugovk hugovk approved these changes
@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@ambv ambv Awaiting requested review from ambv

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@AA-Turner @miss-islington @vstinner @hugovk @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.