GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix argument ordering of embuilder command by OmniTroid · Pull Request #109863 · python/cpython

Conversation

@OmniTroid

@OmniTroid OmniTroid commented Sep 25, 2023

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@OmniTroid
Fix argument ordering of embuilder command
9437bad
@OmniTroid
OmniTroid requested a review from brettcannon as a code owner September 25, 2023 17:32
@ghost

ghost commented Sep 25, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting review label Sep 25, 2023
@bedevere-app

bedevere-app Bot commented Sep 25, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner

AA-Turner commented Sep 25, 2023

Copy link
Copy Markdown
Member

Please can you explain this change?

A
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner AA-Turner added docs Documentation in the Doc dir skip news build The build process and cross-build labels Sep 25, 2023
@brettcannon brettcannon added the OS-wasi label Sep 25, 2023
@OmniTroid

OmniTroid commented Sep 26, 2023

Copy link
Copy Markdown
Contributor Author

Yes, the existing command
embuilder build --pic zlib bzip2 MINIMAL_PIC
fails with
embuilder.py: error: unrecognized arguments: zlib bzip2 MINIMAL_PIC
because the arguments are passed in the wrong order. The correct usage is as follows:

usage: embuilder.py [-h] [--lto] [--lto=thin] [--pic] [--force] [--verbose] [--wasm64]
                    {build,clear,rebuild} [targets ...]

Which means the correct order of arguments is
embuilder --pic build zlib bzip2 MINIMAL_PIC
AA-Turner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
brettcannon
brettcannon approved these changes Sep 26, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 26, 2023
@brettcannon brettcannon added the skip issue label Sep 26, 2023
@brettcannon
Merge branch 'main' into wasm-readme-embuilder
a2b82e0
@brettcannon brettcannon self-assigned this Sep 26, 2023
@brettcannon
brettcannon merged commit 4390c13 into python:main Sep 26, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 26, 2023
@OmniTroid
OmniTroid deleted the wasm-readme-embuilder branch September 27, 2023 07:03
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@OmniTroid @csm10495
Fix argument ordering of embuilder command documented in `Tools/wasm/…
aef7403 
…README.md` (pythonGH-109863)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@OmniTroid @Glyphack
Fix argument ordering of embuilder command documented in `Tools/wasm/…
c81268c 
…README.md` (pythonGH-109863)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@brettcannon brettcannon

Labels

build The build process and cross-build docs Documentation in the Doc dir OS-wasi skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@OmniTroid @AA-Turner @brettcannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.