GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109408: Stop running patchcheck in CI by AA-Turner · Pull Request #109895 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Sep 26, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Requires #109854; #109890; and #109891

  • Issue: Move Azure Pipelines CI to GitHub Actions #109408

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@AA-Turner AA-Turner added skip news DO-NOT-MERGE labels Sep 26, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 26, 2023
Move Azure Pipelines CI to GitHub Actions #109408
Closed
merwok
merwok reviewed Sep 26, 2023
View reviewed changes
Comment thread Tools/patchcheck/patchcheck.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

merwok
merwok reviewed Sep 26, 2023
View reviewed changes
Comment thread Tools/patchcheck/patchcheck.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@AA-Turner
Don't run patchcheck in CI
269bebe
@AA-Turner
AA-Turner force-pushed the patchcheck/delete-azure-pipelines branch from d707f5c to 269bebe Compare July 26, 2024 22:30
@AA-Turner AA-Turner mentioned this pull request Jul 26, 2024
GH-109408: Add a make lint target #122333
Open
@AA-Turner AA-Turner removed the DO-NOT-MERGE label Jul 26, 2024
@AA-Turner
AA-Turner marked this pull request as ready for review July 26, 2024 23:04
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 26, 2024
@AA-Turner

AA-Turner commented Jul 26, 2024

Copy link
Copy Markdown
Member Author

If I understand Éric's comments correctly, they don't block this PR itself, but more speak to improving the experience of running CPython's linting tools. In an effort to unblock this PR, I have opened #122333 as a sketch proposal.

A

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@merwok

merwok commented Jul 27, 2024

Copy link
Copy Markdown
Member

I’m not active enough for my comments to have weight here. But you could have a discussion in the core-dev discuss forum to check agreement and avoid people being surprised after the fact.

AA-Turner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AA-Turner

AA-Turner commented Jul 27, 2024

Copy link
Copy Markdown
Member Author

But you could have a discussion in the core-dev discuss forum to check agreement and avoid people being surprised after the fact.

We did last year (https://discuss.python.org/t/34743), which I don't think raised any opposition to removing the (now duplicative) whitespace checks in CI. The wider patchcheck tool will remain, and #122333 will hopefully give us a unified 'local static checks' target. If/when that's merged, I think telling people on Discourse as a reminder would be useful.

A

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk hugovk changed the title GH-109408: Stop running patchcheck in CI gh-109408: Stop running patchcheck in CI Jul 27, 2024
@AA-Turner

AA-Turner commented Aug 3, 2024

Copy link
Copy Markdown
Member Author

It's been a week or so with no comment (and a year since the PR was opened), so I'll go ahead and merge this. If things go wrong we can always revert.

A

hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AA-Turner
AA-Turner merged commit cc6839a into python:main Aug 3, 2024
@AA-Turner
AA-Turner deleted the patchcheck/delete-azure-pipelines branch August 3, 2024 11:52
@bedevere-app bedevere-app Bot removed the awaiting core review label Aug 3, 2024
brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull request Aug 7, 2024
@AA-Turner @brandtbucher
pythonGH-109408: Stop running patchcheck in CI (python#109895)
ae5e38d
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@AA-Turner @blhsing
pythonGH-109408: Stop running patchcheck in CI (python#109895)
fe713fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok left review comments
@hugovk hugovk hugovk left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AA-Turner @merwok @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.