GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-102304: doc: Add links to Stable ABI and Limited C API (#105345) (#105371) by AA-Turner · Pull Request #109901 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Sep 26, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

  • Move _Py_RefTotal to PyInterpreterState #102304: doc: Add links to Stable ABI and Limited C API (gh-102304: doc: Add links to Stable ABI and Limited C API #105345)

  • Add "limited-c-api" and "stable-api" references.

  • Rename "stable-abi-list" reference to "limited-api-list".

  • Makefile: Document files regenerated by "make regen-limited-abi"

  • Remove first empty line in generated files:

    • Lib/test/test_stable_abi_ctypes.py
    • PC/python3dll.c

(cherry picked from commit bae415a)

  • Move _Py_RefTotal to PyInterpreterState #102304: Fix up Simple ABI doc (gh-102304: Enhance Simple ABI doc #105351)

(cherry picked from commit 0202aa0) (cherry picked from commit 82ab13c)

These targets were added for 3.13 and 3.12, but they're needed for the devguide: python/devguide#1167

A

📚 Documentation preview 📚: https://cpython-previews--109901.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
AA-Turner requested review from erlend-aasland and vstinner September 26, 2023 12:53
@AA-Turner
AA-Turner requested a review from a team as a code owner September 26, 2023 12:53
@bedevere-app bedevere-app Bot added the awaiting review label Sep 26, 2023
This was referenced Sep 26, 2023
Move _Py_RefTotal to PyInterpreterState #102304
Closed
[3.12] gh-102304: doc: Add links to Stable ABI and Limited C API (#105345) #105371
Merged
@bedevere-app bedevere-app Bot added the skip news label Sep 26, 2023
@vstinner @AA-Turner
[3.11] pythongh-102304: doc: Add links to Stable ABI and Limited C API (
e4154d4 
python#105345) (python#105371)

* pythongh-102304: doc: Add links to Stable ABI and Limited C API (python#105345)

* Add "limited-c-api" and "stable-api" references.
* Rename "stable-abi-list" reference to "limited-api-list".
* Makefile: Document files regenerated by "make regen-limited-abi"
* Remove first empty line in generated files:

  - Lib/test/test_stable_abi_ctypes.py
  - PC/python3dll.c

(cherry picked from commit bae415a)

* pythongh-102304: Fix up Simple ABI doc (pythonGH-105351)

(cherry picked from commit 0202aa0)
(cherry picked from commit 82ab13c)
@AA-Turner
AA-Turner force-pushed the backport-82ab13c-3.11 branch from 967be20 to e4154d4 Compare September 26, 2023 12:54
@erlend-aasland

erlend-aasland commented Sep 26, 2023

Copy link
Copy Markdown
Contributor

Unfortunately, bae415a does a lot of things:

  • doc updates
  • C source updates
  • script updates

AFAICS, only the doc updates are relevant for python/devguide#1167? @vstinner, should the whole commit be backported, or only parts of it?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Sep 26, 2023

Copy link
Copy Markdown
Member

It's up to you, I don't know. I understood that the doc should look the same in all branches: all doc changes should be backported.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
Re-Revert
9cfefca
@AA-Turner

AA-Turner commented Sep 26, 2023

Copy link
Copy Markdown
Member Author

should the whole commit be backported, or only parts of it?

I'd intended to only backport the documentation changes; something went wrong in preparing this PR. But if we want to backport everything happy to update the PR, I just wanted to err on the cautious side.

A
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Sep 26, 2023

Copy link
Copy Markdown
Contributor

It's up to you, I don't know. I understood that the doc should look the same in all branches: all doc changes should be backported.

The problem is that the original commit is not a doc change; it changes a lot of non-doc stuff.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland reviewed Sep 26, 2023
View reviewed changes
Comment thread Doc/c-api/stable.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland approved these changes Sep 26, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 26, 2023
@erlend-aasland

erlend-aasland commented Sep 27, 2023

Copy link
Copy Markdown
Contributor

@AA-Turner, could you write comment that sums up this change (for the merge commit message)?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner

AA-Turner commented Sep 29, 2023

Copy link
Copy Markdown
Member Author

First draft:

Add links to the Stable ABI and Limited C API

  • Add "limited-c-api" and "stable-api" targets
  • Rename the "stable-abi-list" target to "limited-api-list"

A
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Sep 29, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland

erlend-aasland commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

First draft:

Looks ok to me!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland merged commit d81bcc2 into python:3.11 Sep 29, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 29, 2023
@AA-Turner
AA-Turner deleted the backport-82ab13c-3.11 branch January 13, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AA-Turner @erlend-aasland @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.