GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove concurrent.futures deadcode: process_result_item() by vstinner · Pull Request #109906 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 26, 2023

Copy link
Copy Markdown
Member

process_result_item() cannot be called with an int anymore, the protocol changed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
Remove concurrent.futures deadcode: process_result_item()
9194686 
process_result_item() cannot be called with an int anymore, the
protocol changed.
@vstinner vstinner added the skip news label Sep 26, 2023
@bedevere-app bedevere-app Bot added the awaiting review label Sep 26, 2023
@vstinner vstinner added the skip issue label Sep 26, 2023
@vstinner

vstinner commented Sep 26, 2023

Copy link
Copy Markdown
Member Author

result_item cannot be an int, otherwise the line after process_result_item() failed, since an int doesn't have an exit_pid attribute:

                self.process_result_item(result_item)

                process_exited = result_item.exit_pid is not None
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit ae1d99c into python:main Sep 26, 2023
@vstinner
vstinner deleted the cf_dead_code branch September 26, 2023 19:34
@bedevere-app bedevere-app Bot removed the awaiting review label Sep 26, 2023
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@vstinner @csm10495
Remove concurrent.futures deadcode: process_result_item() (python#109906
3c55b15 
)

process_result_item() cannot be called with an int anymore, the
protocol changed.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @Glyphack
Remove concurrent.futures deadcode: process_result_item() (python#109906
acc5aa7 
)

process_result_item() cannot be called with an int anymore, the
protocol changed.
@ngoldbaum ngoldbaum mentioned this pull request Oct 7, 2026
gh-158570: Fix ProcessPoolExecutor shutdown deadlock when the result pipe is full #158571
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.