GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109740: Use 't' in `--disable-gil` SOABI by colesbury · Pull Request #109922 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Sep 26, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Shared libraries for CPython 3.13 --disable-gil builds are now marked with a 't' for threading. For example, binascii.cpython-313t-darwin.so.

  • Issue: Include "t" in ABI tag for --disable-gil builds #109740

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gpshead, mara004, dichen-cd, and yanxiu0614 reacted with thumbs up emoji
All reactions
  • 👍 4 reactions
@colesbury
pythongh-109740: Use 't' in --disable-gil SOABI
e745f32
Shared libraries for CPython 3.13 are now marked with a 't' for
threading. For example, `binascii.cpython-313t-darwin.so`.
@colesbury
colesbury requested review from brettcannon, gpshead and vstinner September 26, 2023 20:16
@colesbury
colesbury requested review from corona10 and erlend-aasland as code owners September 26, 2023 20:16
@bedevere-app bedevere-app Bot added the awaiting review label Sep 26, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 26, 2023
Include "t" in ABI tag for --disable-gil builds #109740
Closed
@colesbury
Use double backticks in blurb
306081b
@colesbury

colesbury commented Sep 26, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Notes for reviewers:

  • I moved the --disable-gil flag up in configure so that it comes before the debug check so that the optional "d" ABI flag appears on the outside (e.g., package-cpython-313td-darwin.so for --disable-gil --with-pydebug). This is purely aesthetic and can be changed, if you prefer.
  • Contrary to what I originally thought, pypa/packaging will need to be updated to compute CPython tags for --disable-gil builds.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland
erlend-aasland reviewed Sep 26, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Build/2023-09-26-16-00-50.gh-issue-109740.wboWdQ.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland
erlend-aasland approved these changes Sep 26, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 26, 2023
@colesbury @erlend-aasland
Update Misc/NEWS.d/next/Build/2023-09-26-16-00-50.gh-issue-109740.wbo…
44f0e17
…WdQ.rst

Co-authored-by: Erlend E. Aasland <[email protected]>
vstinner
vstinner reviewed Sep 26, 2023
View reviewed changes
Comment thread Lib/test/test_sys.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.

@colesbury
Add comment about ABIFLAGS
0dbbbce
vstinner
vstinner approved these changes Sep 26, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but i left a few minor suggestions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Python/dynload_win.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread configure.ac Resolved

Uh oh!

There was an error while loading. Please reload this page.

corona10
corona10 approved these changes Sep 27, 2023
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
vstinner added 3 commits September 27, 2023 10:04
@vstinner
Update configure.ac
964e379
@vstinner
Update Python/dynload_win.c
39dec48
@vstinner
sys.abiflags is not available on Windows
597e489
@vstinner
vstinner enabled auto-merge (squash) September 27, 2023 08:07
@vstinner

vstinner commented Sep 27, 2023

Copy link
Copy Markdown
Member

I included my suggested changes to be able to merge your PR more quickly ;-)

colesbury reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Sep 27, 2023

Copy link
Copy Markdown
Contributor

I included my suggested changes to be able to merge your PR more quickly ;-)

You need to regen configure.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
Run make regen-configure
c985f63
@vstinner
vstinner disabled auto-merge September 27, 2023 08:38
@vstinner
vstinner enabled auto-merge (squash) September 27, 2023 08:39
@vstinner

vstinner commented Sep 27, 2023

Copy link
Copy Markdown
Member

You need to regen configure.

Oops. Otherwise, it would be too easy! Done.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@colesbury

colesbury commented Sep 27, 2023

Copy link
Copy Markdown
Contributor Author

Thanks!

erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Sep 27, 2023

Copy link
Copy Markdown
Member

Windows x64 unstable tests:

FAIL: test_future_times_out (test.test_concurrent_futures.test_as_completed.ThreadPoolAsCompletedTest.test_future_times_out) [0.01]

Should be already fixed by PR #109949.

FAIL: test_set_and_clear (test.test_threading.EventTests.test_set_and_clear)

I created issue #109974 for this failure.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner merged commit 773614e into python:main Sep 27, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 27, 2023
@vstinner

vstinner commented Sep 27, 2023

Copy link
Copy Markdown
Member

Good, it got merged after a few CI hiccups :-)

colesbury and erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@colesbury
colesbury deleted the abi branch September 27, 2023 15:29
csm10495 pushed a commit to csm10495/cpython that referenced this pull request Sep 28, 2023
@colesbury @csm10495
pythongh-109740: Use 't' in --disable-gil SOABI (python#109922)
9e0dbb9
Shared libraries for CPython 3.13 are now marked with a 't' for
threading. For example, `binascii.cpython-313t-darwin.so`.
@vstinner

vstinner commented Oct 4, 2023

Copy link
Copy Markdown
Member

The test broke test_importlib on Windows: see issue gh-110359.

FAIL: test_tagged_suffix (test.test_importlib.test_windows.Source_WindowsExtensionSuffixTests.test_tagged_suffix)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_importlib\test_windows.py", line 122, in test_tagged_suffix
    self.assertIn(expected_tag, suffixes)
AssertionError: '_d.cp313-win32.pyd' not found in ['_d.cp313t-win_amd64.pyd', '_d.pyd']
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@radarhere radarhere mentioned this pull request Feb 16, 2024
Pin Python 3.13 on Windows to a3 python-pillow/Pillow#7805
Merged
@hugovk hugovk mentioned this pull request Feb 20, 2024
CI: Temporarily pin to 3.13.0a3 for Windows coveragepy/coveragepy#1751
Merged
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@colesbury @Glyphack
pythongh-109740: Use 't' in --disable-gil SOABI (python#109922)
292ac4f
Shared libraries for CPython 3.13 are now marked with a 't' for
threading. For example, `binascii.cpython-313t-darwin.so`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@corona10 corona10 corona10 approved these changes
@erlend-aasland erlend-aasland erlend-aasland approved these changes
@brettcannon brettcannon Awaiting requested review from brettcannon
@gpshead gpshead Awaiting requested review from gpshead

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@colesbury @vstinner @erlend-aasland @corona10
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.