GeezerVison is showing github.com — gh-109740: Use 't' in `--disable-gil` SOABI by colesbury · Pull Request #109922 · python/cpython
Conversation
colesbury
commented
Sep 26, 2023
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Shared libraries for CPython 3.13 --disable-gil builds are now marked with a 't' for threading. For example, binascii.cpython-313t-darwin.so.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
gpshead, mara004, dichen-cd, and yanxiu0614 reacted with thumbs up emoji
Shared libraries for CPython 3.13 are now marked with a 't' for
threading. For example, `binascii.cpython-313t-darwin.so`.
colesbury
commented
Sep 26, 2023
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
Notes for reviewers:
- I moved the
--disable-gil flag up in configure so that it comes before the debug check so that the optional "d" ABI flag appears on the outside (e.g., package-cpython-313td-darwin.so for --disable-gil --with-pydebug). This is purely aesthetic and can be changed, if you prefer.
- Contrary to what I originally thought,
pypa/packaging will need to be updated to compute CPython tags for --disable-gil builds.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but i left a few minor suggestions.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
I included my suggested changes to be able to merge your PR more quickly ;-)
|
colesbury reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
I included my suggested changes to be able to merge your PR more quickly ;-)
You need to regen configure.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
You need to regen configure.
Oops. Otherwise, it would be too easy! Done.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
erlend-aasland reacted with heart emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Windows x64 unstable tests:
FAIL: test_future_times_out (test.test_concurrent_futures.test_as_completed.ThreadPoolAsCompletedTest.test_future_times_out) [0.01]
Should be already fixed by PR #109949.
FAIL: test_set_and_clear (test.test_threading.EventTests.test_set_and_clear)
I created issue #109974 for this failure.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Good, it got merged after a few CI hiccups :-)
|
colesbury and erlend-aasland reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
csm10495
pushed a commit
to csm10495/cpython
that referenced
this pull request
Sep 28, 2023
Shared libraries for CPython 3.13 are now marked with a 't' for
threading. For example, `binascii.cpython-313t-darwin.so`.
|
The test broke test_importlib on Windows: see issue gh-110359.
FAIL: test_tagged_suffix (test.test_importlib.test_windows.Source_WindowsExtensionSuffixTests.test_tagged_suffix)
----------------------------------------------------------------------
Traceback (most recent call last):
File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_importlib\test_windows.py", line 122, in test_tagged_suffix
self.assertIn(expected_tag, suffixes)
AssertionError: '_d.cp313-win32.pyd' not found in ['_d.cp313t-win_amd64.pyd', '_d.pyd']
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Shared libraries for CPython 3.13 are now marked with a 't' for
threading. For example, `binascii.cpython-313t-darwin.so`.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|