GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-107888: Fix test_mmap.test_access_parameter() on macOS 14 (GH-109928) by miss-islington · Pull Request #109929 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 26, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 9dbfe2d)

Co-authored-by: Victor Stinner [email protected]

  • Issue: test_mmap.test_access_parameter failing on macOS Sonoma 14.0 beta on Apple Silicon #107888

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Sep 26, 2023
This was referenced Sep 26, 2023
test_mmap.test_access_parameter failing on macOS Sonoma 14.0 beta on Apple Silicon #107888
Closed
gh-107888: Fix test_mmap.test_access_parameter() on macOS 14 #109928
Merged
@bedevere-app bedevere-app Bot added the skip news label Sep 26, 2023
vstinner
vstinner approved these changes Sep 26, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 26, 2023
Yhg1s
Yhg1s reviewed Sep 27, 2023
View reviewed changes
Comment thread Lib/test/test_mmap.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ned-deily ned-deily mentioned this pull request Sep 28, 2023
test_mmap: test_access_parameter() failed on ARM64 macOS 3.x with macOS 14 Sonoma #109916
Closed
@vstinner
pythongh-107888: Fix test_mmap.test_access_parameter() on macOS 14 (p…
9820232 
…ythonGH-109928)

(cherry picked from commit 9dbfe2d)

Co-authored-by: Victor Stinner <[email protected]>
@vstinner
vstinner force-pushed the backport-9dbfe2d-3.12 branch from c2a2204 to 9820232 Compare September 29, 2023 22:00
@vstinner

vstinner commented Sep 29, 2023

Copy link
Copy Markdown
Member

I included my comment fix into this backport: #110125
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Yhg1s
Yhg1s merged commit bb35fc3 into python:3.12 Oct 2, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 2, 2023
@miss-islington
miss-islington deleted the backport-9dbfe2d-3.12 branch October 2, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@Yhg1s Yhg1s Yhg1s left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @vstinner @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.