GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-107888: Fix test_mmap PROT_EXEC comment by vstinner · Pull Request #110125 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 29, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: test_mmap.test_access_parameter failing on macOS Sonoma 14.0 beta on Apple Silicon #107888

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-107888: Fix test_mmap PROT_EXEC comment
24c06ce
@vstinner vstinner added skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 29, 2023
@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Sep 29, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 29, 2023
test_mmap.test_access_parameter failing on macOS Sonoma 14.0 beta on Apple Silicon #107888
Closed
@vstinner
vstinner merged commit 14098b7 into python:main Sep 29, 2023
@vstinner
vstinner deleted the test_mmap_comment branch September 29, 2023 21:56
@miss-islington

miss-islington commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Sep 29, 2023
@miss-islington

miss-islington commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 14098b78f7453adbd40c53e32c29588611b7c87b 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned vstinner Sep 29, 2023
@bedevere-app

bedevere-app Bot commented Sep 29, 2023

Copy link
Copy Markdown

GH-110130 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 29, 2023
@vstinner @miss-islington
pythongh-107888: Fix test_mmap PROT_EXEC comment (pythonGH-110125)
f033430 
(cherry picked from commit 14098b7)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Sep 29, 2023
@vstinner vstinner added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels Sep 29, 2023
@miss-islington

miss-islington commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 14098b78f7453adbd40c53e32c29588611b7c87b 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner added a commit to vstinner/cpython that referenced this pull request Sep 29, 2023
@vstinner
pythongh-107888: Fix test_mmap PROT_EXEC comment (python#110125)
8ca084c 
(cherry picked from commit 14098b7)
@vstinner vstinner mentioned this pull request Sep 29, 2023
[3.12] gh-107888: Fix test_mmap.test_access_parameter() on macOS 14 (GH-109928) #109929
Merged
vstinner added a commit that referenced this pull request Sep 29, 2023
@miss-islington @vstinner
[3.11] gh-107888: Fix test_mmap PROT_EXEC comment (GH-110125) (#110130)
42b6883 
gh-107888: Fix test_mmap PROT_EXEC comment (GH-110125)
(cherry picked from commit 14098b7)

Co-authored-by: Victor Stinner <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @Glyphack
pythongh-107888: Fix test_mmap PROT_EXEC comment (python#110125)
a59e44d
@hugovk hugovk removed the needs backport to 3.12 only security fixes label Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@vstinner vstinner

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @miss-islington @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.