GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-85984: Document change in return type of tty functions by JelleZijlstra · Pull Request #110028 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Sep 28, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Followup from #101832

  • Issue: Lib/pty.py major revision #85984

📚 Documentation preview 📚: https://cpython-previews--110028.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
pythongh-85984: Document change in return type of tty functions
4c49b2b
@JelleZijlstra JelleZijlstra added skip news needs backport to 3.12 only security fixes labels Sep 28, 2023
@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir labels Sep 28, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 28, 2023
Lib/pty.py major revision #85984
Open
@JelleZijlstra JelleZijlstra mentioned this pull request Sep 28, 2023
[tty] py312: Fix return types of set(raw|cbreak) python/typeshed#10785
Merged
srittau
srittau approved these changes Sep 28, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Sep 28, 2023
@JelleZijlstra

JelleZijlstra commented Oct 4, 2023

Copy link
Copy Markdown
Member Author

cc @8vasu and @gpshead as the author and merger of the PR that made this change
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gpshead
gpshead approved these changes Oct 4, 2023
View reviewed changes
@gpshead
gpshead merged commit f02f26e into python:main Oct 4, 2023
@miss-islington

miss-islington commented Oct 4, 2023

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 4, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 4, 2023
@JelleZijlstra @miss-islington
pythongh-85984: Document change in return type of tty functions (pyth…
c59cd3b 
…onGH-110028)

(cherry picked from commit f02f26e)

Co-authored-by: Jelle Zijlstra <[email protected]>
@bedevere-app

bedevere-app Bot commented Oct 4, 2023

Copy link
Copy Markdown

GH-110324 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 4, 2023
vstinner pushed a commit that referenced this pull request Oct 4, 2023
@miss-islington @JelleZijlstra
[3.12] gh-85984: Document change in return type of tty functions (GH-…
7ec3487 
…110028) (#110324)

gh-85984: Document change in return type of tty functions (GH-110028)
(cherry picked from commit f02f26e)

Co-authored-by: Jelle Zijlstra <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@JelleZijlstra @Glyphack
pythongh-85984: Document change in return type of tty functions (pyth…
fc7925e 
…on#110028)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
+1 more reviewer
@srittau srittau srittau approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JelleZijlstra @miss-islington @srittau @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.