GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-110014: Include explicitly <unistd.h> header by vstinner · Pull Request #110155 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 30, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Remove unused <locale.h> include.
  • Remove <fcntl.h> include in traceback.h.
  • Remove redundant include: <assert.h> and <stddef.h> are already included by "Python.h".
  • Remove <object.h> include in faulthandler.c.
  • Add missing <stdbool.h> in pycore_pythread.h if HAVE_PTHREAD_STUBS is defined.
  • Fix also warnings in pthread_stubs.h: don't redefine macros if they are already defined, like the __NEED_pthread_t macro.
  • Issue: GCC warnings on pycore_semaphore.h and Python/parking_lot.c #110014

📚 Documentation preview 📚: https://cpython-previews--110155.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner vstinner added the skip news label Sep 30, 2023
@vstinner
vstinner requested review from iritkatriel, lysnikolaou, pablogsal and rhettinger as code owners September 30, 2023 19:30
@bedevere-app bedevere-app Bot added the awaiting review label Sep 30, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 30, 2023
GCC warnings on pycore_semaphore.h and Python/parking_lot.c #110014
Closed
@vstinner
pythongh-110014: Include explicitly <unistd.h> header
d7b3e46 
* Remove unused <locale.h> include.
* Remove <fcntl.h> include in traceback.h.
* Remove redundant include: <assert.h> and <stddef.h> are already
  included by "Python.h".
* Remove <object.h> include in faulthandler.c.
* Add missing <stdbool.h> in pycore_pythread.h if HAVE_PTHREAD_STUBS
  is defined.
* Fix also warnings in pthread_stubs.h: don't redefine macros if they
  are already defined, like the __NEED_pthread_t macro.
@vstinner
vstinner force-pushed the unistd3 branch from 85d4c17 to d7b3e46 Compare September 30, 2023 19:36
@vstinner

vstinner commented Sep 30, 2023

Copy link
Copy Markdown
Member Author

Oh. It seems like WASM/WASI builds are badly broken. I'm not sure if it's related to my commit 74e425e or not.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Sep 30, 2023
gh-110014: Fix _POSIX_THREADS and _POSIX_SEMAPHORES usage #110139
Merged
@vstinner
vstinner enabled auto-merge (squash) September 30, 2023 19:57
@vstinner
vstinner merged commit 7513994 into python:main Sep 30, 2023
@vstinner
vstinner deleted the unistd3 branch September 30, 2023 20:06
@bedevere-app bedevere-app Bot removed the awaiting review label Sep 30, 2023
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@vstinner @Glyphack
pythongh-110014: Include explicitly <unistd.h> header (python#110155)
e0f276d 
* Remove unused <locale.h> includes.
* Remove unused <fcntl.h> include in traceback.h.
* Remove redundant <assert.h> and <stddef.h> includes. They  are already
  included by "Python.h".
* Remove <object.h> include in faulthandler.c. Python.h already includes it.
* Add missing <stdbool.h> in pycore_pythread.h if HAVE_PTHREAD_STUBS
  is defined.
* Fix also warnings in pthread_stubs.h: don't redefine macros if they
  are already defined, like the __NEED_pthread_t macro.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@iritkatriel iritkatriel Awaiting requested review from iritkatriel

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.