GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — DOC: Reuse old bltin-boolean-values ref tag by pllim · Pull Request #110371 · python/cpython

Conversation

@pllim

@pllim pllim commented Oct 4, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

gh-103487: Reuse old bltin-boolean-values ref tag to avoid breaking downstream intersphinx via numpydoc

The PR is opened as suggested in https://github.com/python/cpython/pull/103487/files#r1346336728 by @hauntsaninja

close astropy/astropy#15428

close numpy/numpydoc#509

📚 Documentation preview 📚: https://cpython-previews--110371.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pllim
DOC: Reuse old bltin-boolean-values ref tag
558f91a 
to avoid breaking downstream intersphinx via numpydoc
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Oct 4, 2023
@pllim
DOC: Revert ref tag change in functions.rst
fcc23d8 
from python#103487
@JelleZijlstra
JelleZijlstra requested a review from hauntsaninja October 4, 2023 19:22
@JelleZijlstra JelleZijlstra added the skip issue label Oct 4, 2023
This was referenced Oct 4, 2023
WARNING: undefined label: 'python:bltin-boolean-values' numpy/numpydoc#509
Closed
gh-82012: Deprecate bitwise inversion (~) of bool #103487
Merged
AlexWaygood
AlexWaygood reviewed Oct 4, 2023
View reviewed changes
Comment thread Doc/library/stdtypes.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
pllim and others added 2 commits October 4, 2023 15:36
@pllim @AlexWaygood
Por que no los dos
f5d5aa6 
[ci skip]

Co-authored-by: Alex Waygood <[email protected]>
@pllim
Revert changes to functions.rst
c855c70
@pllim

pllim commented Oct 4, 2023

Copy link
Copy Markdown
Contributor Author

p.s. If you don't want to use the "Squash and merge" button, please let me know so I can clone the repo properly and squash it by hand.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hauntsaninja hauntsaninja added the needs backport to 3.12 only security fixes label Oct 4, 2023
@AlexWaygood

AlexWaygood commented Oct 4, 2023

Copy link
Copy Markdown
Member

p.s. If you don't want to use the "Squash and merge" button, please let me know so I can clone the repo properly and squash it by hand.

We always use "squash and merge" at CPython, no worries :)
pllim reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hauntsaninja
hauntsaninja merged commit f786029 into python:main Oct 4, 2023
@bedevere-app bedevere-app Bot removed the awaiting review label Oct 4, 2023
@miss-islington

miss-islington commented Oct 4, 2023

Copy link
Copy Markdown
Contributor

Thanks @pllim for the PR, and @hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
pllim reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hauntsaninja

hauntsaninja commented Oct 4, 2023

Copy link
Copy Markdown
Contributor

Thank you!
pllim reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 4, 2023
@pllim @miss-islington
Add back bltin-boolean-values ref tag (pythonGH-110371)
e87de28 
To avoid breaking downstream intersphinx via numpydoc
(cherry picked from commit f786029)

Co-authored-by: P. L. Lim <[email protected]>
@bedevere-app

bedevere-app Bot commented Oct 4, 2023

Copy link
Copy Markdown

GH-110372 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 4, 2023
@pllim
pllim deleted the patch-1 branch October 4, 2023 19:58
@pllim

pllim commented Oct 4, 2023

Copy link
Copy Markdown
Contributor Author

Thank you for the quick reviews and resolution!
AlexWaygood reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hauntsaninja pushed a commit that referenced this pull request Oct 4, 2023
@miss-islington @pllim
[3.12] Add back bltin-boolean-values ref tag (GH-110371) (#110372)
36a7d6b 
Add back bltin-boolean-values ref tag (GH-110371)

To avoid breaking downstream intersphinx via numpydoc
(cherry picked from commit f786029)

Co-authored-by: P. L. Lim <[email protected]>
@pllim

pllim commented Oct 5, 2023

Copy link
Copy Markdown
Contributor Author

By the way, how soon will https://docs.python.org/3/ point to the updated doc with this patch? 👀
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood

AlexWaygood commented Oct 5, 2023

Copy link
Copy Markdown
Member

By the way, how soon will https://docs.python.org/3/ point to the updated doc with this patch? 👀

I think the docs are rebuilt once a day!
pllim reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pllim pllim mentioned this pull request Oct 5, 2023
Reverts PR 15433 (Use Python 3.11 for intersphinx links to avoid 3.12 warnings) astropy/astropy#15445
Merged
1 task
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@pllim @Glyphack
Add back bltin-boolean-values ref tag (python#110371)
3b430a9 
To avoid breaking downstream intersphinx via numpydoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments
@hauntsaninja hauntsaninja Awaiting requested review from hauntsaninja

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

WARNING: undefined label: 'python:bltin-boolean-values' RTD fails with WARNING: undefined label: 'python:bltin-boolean-values'

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@pllim @AlexWaygood @miss-islington @hauntsaninja @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.