GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-110109: Speed up `pathlib._PathBase.resolve()` by barneygale · Pull Request #110412 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented Oct 5, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Add fast path to _split_stack()
  • Skip unnecessarily resolution of the current directory when a relative path is given to resolve()
  • Remove stat and target caches, which slow down most resolve() calls in practice.
  • Slightly refactor code for clarity.
  • Issue: User-defined virtual path objects #110109

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@barneygale
pythonGH-110109: Speed up pathlib._PathBase.resolve()
7321dbd 
- Add fast path to `_split_stack()`
- Skip unnecessarily resolution of the current directory when a relative
  path is given to `resolve()`
- Remove stat and target caches, which slow down most `resolve()` calls in
  practice.
- Slightly refactor code for clarity.
@barneygale barneygale added performance Performance or resource usage topic-pathlib labels Oct 5, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 5, 2023
User-defined virtual path objects #110109
Closed
8 tasks done
@barneygale barneygale added the skip news label Oct 5, 2023
@barneygale
barneygale marked this pull request as ready for review October 5, 2023 19:45
@bedevere-app bedevere-app Bot added the awaiting review label Oct 5, 2023
barneygale added 2 commits November 13, 2023 21:19
@barneygale
Merge branch 'main' into pythongh-110109-pathbase-resolve-speedups
4346183
@barneygale
Merge branch 'main' into pythongh-110109-pathbase-resolve-speedups
482752f
@barneygale

barneygale commented Nov 17, 2023

Copy link
Copy Markdown
Contributor Author

This method can't yet be invoked using public APIs, so there's little risk here. Merging!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale
barneygale merged commit 9fb0f2d into python:main Nov 17, 2023
@bedevere-app bedevere-app Bot removed the awaiting review label Nov 17, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@barneygale @aisk
pythonGH-110109: Speed up pathlib._PathBase.resolve() (python#110412)
88040b4 
- Add fast path to `_split_stack()`
- Skip unnecessarily resolution of the current directory when a relative
  path is given to `resolve()`
- Remove stat and target caches, which slow down most `resolve()` calls in
  practice.
- Slightly refactor code for clarity.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@barneygale @Glyphack
pythonGH-110109: Speed up pathlib._PathBase.resolve() (python#110412)
8d7ec2b 
- Add fast path to `_split_stack()`
- Skip unnecessarily resolution of the current directory when a relative
  path is given to `resolve()`
- Remove stat and target caches, which slow down most `resolve()` calls in
  practice.
- Slightly refactor code for clarity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

performance Performance or resource usage skip news topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@barneygale
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.