GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104909: Make LOAD_ATTR_PROPERTY a viable uop by gvanrossum · Pull Request #110560 · python/cpython

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Oct 9, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There are severe problems here.

LOAD_ATTR_PROPERTY takes a func_version cache entry an an fget cache entry, which need to be cross-checked (fget->func_version == func_version) but a single uop cannot reference two cache entries.

The immediate fix (after rearranging the cache entries) is to load fget onto the stack. However, this isn't safe, because it will break when DEOPT_IF() jumps back to the unspecialized opcode (since the stack is different).

Moreover, I needed to disable two assertions from the code generator. It's possible there's a better way, but I'd have to think, and it's not worth it unless we solve the other problem.

This draft PR just exists to find out what else CI finds.

  • Issue: Split opcodes into micro-ops #104909

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@gvanrossum gvanrossum added the DO-NOT-MERGE label Oct 9, 2023
@gvanrossum
gvanrossum force-pushed the load-attr-uops branch from 8dcbe3a to fff4211 Compare October 10, 2023 11:40
@gvanrossum
gvanrossum force-pushed the load-attr-uops branch 2 times, most recently from 2deceef to 067b489 Compare November 1, 2023 22:59
@gvanrossum gvanrossum mentioned this pull request Nov 1, 2023
Tier 2 IR format is not flexible enough for LOAD_ATTR_PROPERTY faster-cpython/ideas#634
Open
@gvanrossum
gvanrossum force-pushed the load-attr-uops branch from 067b489 to 99ec298 Compare November 18, 2023 02:27
@gvanrossum gvanrossum changed the title DRAFT: Load attr uops gh-104909: Make LOAD_ATTR_PROPERTY a viable uop Nov 18, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Nov 18, 2023
Split opcodes into micro-ops #104909
Closed
gvanrossum added 3 commits November 17, 2023 22:18
@gvanrossum
Rearrange cache for LOAD_ATTR_PROPERTY
3a0e8ea
@gvanrossum
Split LOAD_ATTR_PROPERTY into uops (but final uop is not yet viable)
5e43670
@gvanrossum
Make _LOAD_ATTR_PROPERTY viable; at the cost of hacks
0b71d63
@gvanrossum
gvanrossum force-pushed the load-attr-uops branch from 99ec298 to 0b71d63 Compare November 18, 2023 06:19
@gvanrossum

gvanrossum commented Nov 18, 2023

Copy link
Copy Markdown
Member Author

Alas, this will go nowhere. (See issue.)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gvanrossum gvanrossum closed this Nov 18, 2023
@gvanrossum
gvanrossum deleted the load-attr-uops branch February 22, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon will be requested when the pull request is marked ready for review markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

DO-NOT-MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.