GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-84570: Implement Waiting in SendChannel.send() by ericsnowcurrently · Pull Request #110565 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Oct 9, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

We had been faking it (poorly).

We will add timeouts separately.

  • Issue: [subinterpreters] Implement _xxsubinterpreters.channel_send_wait() #84570

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 4 commits October 9, 2023 07:45
@ericsnowcurrently
Implement waiting for _channels.send().
c617361
@ericsnowcurrently
Release the GIL while waiting for the send lock.
1701ca0
@ericsnowcurrently
Fix tests.
b5dbf81
@ericsnowcurrently
Update the doc strings.
d3aefb8
@ericsnowcurrently ericsnowcurrently added the skip news label Oct 9, 2023
@bedevere-app bedevere-app Bot added the awaiting review label Oct 9, 2023
@ericsnowcurrently ericsnowcurrently changed the title Implement Waiting in SendChannel.send() gh-84570: Implement Waiting in SendChannel.send() Oct 9, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 9, 2023
[subinterpreters] Implement _xxsubinterpreters.channel_send_wait() #84570
Closed
@ericsnowcurrently ericsnowcurrently mentioned this pull request Oct 9, 2023
bpo-32604: [_xxsubinterpreters] Add channel_send_wait(). #19829
Closed
ericsnowcurrently added 3 commits October 9, 2023 08:18
@ericsnowcurrently
Wait when receiving from a thread.
5b6574e
@ericsnowcurrently
wait -> blocking
fbd7945
@ericsnowcurrently
Fix the tests.
b85a681
@ericsnowcurrently
ericsnowcurrently enabled auto-merge (squash) October 10, 2023 09:23
@ericsnowcurrently
ericsnowcurrently merged commit 757cc35 into python:main Oct 10, 2023
@bedevere-app bedevere-app Bot removed the awaiting review label Oct 10, 2023
@ericsnowcurrently
ericsnowcurrently deleted the channel-send-wait-new branch October 10, 2023 09:38
@ericsnowcurrently ericsnowcurrently mentioned this pull request Oct 17, 2023
gh-84570: Send-Wait Fixes for _xxinterpchannels #111006
Merged
ericsnowcurrently added a commit that referenced this pull request Oct 17, 2023
@ericsnowcurrently
gh-84570: Send-Wait Fixes for _xxinterpchannels (gh-111006)
a53d7cb 
There were a few things I did in gh-110565 that need to be fixed. I also forgot to add tests in that PR.

(Note that this PR exposes a refleak introduced by gh-110246. I'll take care of that separately.)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@ericsnowcurrently @aisk
pythongh-84570: Send-Wait Fixes for _xxinterpchannels (pythongh-111006)
0301f3b 
There were a few things I did in pythongh-110565 that need to be fixed. I also forgot to add tests in that PR.

(Note that this PR exposes a refleak introduced by pythongh-110246. I'll take care of that separately.)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@ericsnowcurrently @Glyphack
pythongh-84570: Implement Waiting in SendChannel.send() (pythongh-110565
6290e1a 
)

We had been faking it (poorly).

We will add timeouts separately.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@ericsnowcurrently @Glyphack
pythongh-84570: Send-Wait Fixes for _xxinterpchannels (pythongh-111006)
934d648 
There were a few things I did in pythongh-110565 that need to be fixed. I also forgot to add tests in that PR.

(Note that this PR exposes a refleak introduced by pythongh-110246. I'll take care of that separately.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@ericsnowcurrently
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.