GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-110572: Fix leaks in `test_*_code` in `_testcapi/getargs.c` by sobolevn · Pull Request #110573 · python/cpython

Conversation

sobolevn commented Oct 9, 2023 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

@erlend-aasland you were suggested by GitHub, would you mind taking a look? :)

Issue: test_*_code functions in _testcapi/getargs.c have memory leaks #110572

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-110572: Fix leaks in test_*_code in _testcapi/getargs.c

e0eec0f

sobolevn requested a review from erlend-aasland

October 9, 2023 16:28

bedevere-app Bot added the awaiting review label

Oct 9, 2023

bedevere-app Bot mentioned this pull request

Oct 9, 2023

test_*_code functions in _testcapi/getargs.c have memory leaks #110572

Closed

sobolevn added the skip news label

Oct 9, 2023

erlend-aasland commented Oct 9, 2023

Copy link

Copy Markdown

Contributor

I'll review it later tonight :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reviewed

Oct 9, 2023

View reviewed changes

Comment thread

Modules/_testcapi/getargs.c Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Address review

073b915

sobolevn force-pushed the issue-110572 branch from b5b5936 to 073b915 Compare

October 9, 2023 22:34


          Merge branch 'main' into issue-110572

b799cb7

sobolevn mentioned this pull request

Oct 10, 2023

gh-107652: Fix CIFuzz build #110576

Merged

erlend-aasland reviewed

Oct 10, 2023

View reviewed changes

Comment thread

Modules/_testcapi/getargs.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka approved these changes

Oct 21, 2023

View reviewed changes

bedevere-app Bot added awaiting merge and removed awaiting review labels

Oct 21, 2023

serhiy-storchaka added the needs backport to 3.12 only security fixes label

Oct 21, 2023

serhiy-storchaka merged commit f71cd53 into python:main

Oct 21, 2023

bedevere-app Bot removed the awaiting merge label

Oct 21, 2023

miss-islington-app Bot commented Oct 21, 2023

Copy link

Copy Markdown

Thanks @sobolevn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 21, 2023


          pythongh-110572: Fix potential leaks in test_*_code in _testcapi/geta…

2413dbd

…rgs.c (pythonGH-110573)

(cherry picked from commit f71cd53)

Co-authored-by: Nikita Sobolev <[email protected]>

bedevere-app Bot commented Oct 21, 2023

Copy link

Copy Markdown

GH-111161 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label

Oct 21, 2023

serhiy-storchaka pushed a commit that referenced this pull request

Oct 21, 2023


          [3.12] gh-110572: Fix potential leaks in test_*_code in _testcapi/get…

552ceb2

…args.c (GH-110573) (GH-111161)

(cherry picked from commit f71cd53)

Co-authored-by: Nikita Sobolev <[email protected]>

aisk pushed a commit to aisk/cpython that referenced this pull request

Feb 11, 2024


          pythongh-110572: Fix potential leaks in test_*_code in _testcapi/geta…

d8bea6a

…rgs.c (pythonGH-110573)

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request

Sep 2, 2024


          pythongh-110572: Fix potential leaks in test_*_code in _testcapi/geta…

45ee0b1

…rgs.c (pythonGH-110573)

Reviewers

erlend-aasland

erlend-aasland left review comments

serhiy-storchaka

serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

sobolevn commented Oct 9, 2023 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erlend-aasland commented Oct 9, 2023

Uh oh!

Uh oh!

Uh oh!

miss-islington-app Bot commented Oct 21, 2023

Uh oh!

bedevere-app Bot commented Oct 21, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sobolevn commented Oct 9, 2023 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.