GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-104584: Fix refleak when tracing through calls by brandtbucher · Pull Request #110593 · python/cpython

Conversation

@brandtbucher

@brandtbucher brandtbucher commented Oct 10, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This modifies _PyFunction_LookupByVersion to return a borrowed reference, which is what the caller assumes (and most internal "lookup" functions do, in general).

  • Issue: Pluggable optimizer API #104584

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
brandtbucher added 3 commits October 10, 2023 00:47
@brandtbucher
_PyFunction_LookupByVersion returns a borrowed ref
da57eed
@brandtbucher
blurb add
f3a6962
@brandtbucher
fixup
1bbea3b
@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Oct 10, 2023
@brandtbucher
brandtbucher requested a review from gvanrossum October 10, 2023 07:58
@brandtbucher brandtbucher self-assigned this Oct 10, 2023
@bedevere-app bedevere-app Bot added the awaiting review label Oct 10, 2023
@brandtbucher brandtbucher changed the title GH-104854: Fix refleak when tracing through calls GH-104584: Fix refleak when tracing through calls Oct 10, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 10, 2023
Pluggable optimizer API #104584
Closed
gvanrossum
gvanrossum approved these changes Oct 10, 2023
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I love how this already violates a likely future C API requirement. Glad that those requirements don't apply to internal APIs. :-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Oct 10, 2023
@brandtbucher
brandtbucher enabled auto-merge (squash) October 10, 2023 08:15
@brandtbucher
brandtbucher merged commit 13380da into python:main Oct 10, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 10, 2023
@gvanrossum
gvanrossum deleted the uops-refleak branch October 10, 2023 09:57
@gvanrossum gvanrossum mentioned this pull request Oct 11, 2023
DO NOT MERGE: Always use -Xuops #107820
Closed
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@brandtbucher @Glyphack
pythonGH-104584: Fix refleak when tracing through calls (pythonGH-110593
9308192 
)
@brandtbucher
brandtbucher restored the uops-refleak branch August 20, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@brandtbucher brandtbucher

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@brandtbucher @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.