GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-110109: Move tests for `pathlib.Path.walk()` into main test classes. by barneygale · Pull Request #110655 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented Oct 10, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This adds some test coverage to pathlib._PathBase.walk()

  • Issue: User-defined virtual path objects #110109

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@barneygale
pythonGH-110109: Move tests for pathlib.Path.walk() into main test …
17511b3 
…classes.

This adds some test coverage to `pathlib._PathBase.walk()`
@barneygale barneygale added tests Tests in the Lib/test dir skip news topic-pathlib labels Oct 10, 2023
@bedevere-app bedevere-app Bot added the awaiting review label Oct 10, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 10, 2023
User-defined virtual path objects #110109
Closed
8 tasks done
@barneygale
Restore directory with no permissions.
47a81dd
JelleZijlstra
JelleZijlstra reviewed Oct 11, 2023
View reviewed changes
Comment thread Lib/test/test_pathlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@barneygale
Add check for path existence in test_walk_symlink_location
9db41d0
@barneygale barneygale mentioned this pull request Oct 13, 2023
maintainership & project lead jazzband/pathlib2#70
Open
@barneygale

barneygale commented Oct 28, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the review :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale
barneygale merged commit 81bc802 into python:main Oct 28, 2023
@bedevere-app bedevere-app Bot removed the awaiting review label Oct 28, 2023
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Oct 29, 2023
@barneygale @iritkatriel
pythonGH-110109: Move tests for pathlib.Path.walk() into main test …
5c9882e 
…classes. (python#110655)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@barneygale @aisk
pythonGH-110109: Move tests for pathlib.Path.walk() into main test …
9721823 
…classes. (python#110655)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@barneygale @Glyphack
pythonGH-110109: Move tests for pathlib.Path.walk() into main test …
b4afa38 
…classes. (python#110655)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@barneygale @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.