GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-109853: Fix sys.path[0] For Subinterpreters (gh-109994) by ericsnowcurrently · Pull Request #110701 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Oct 11, 2023

Copy link
Copy Markdown
Member

This change makes sure sys.path[0] is set properly for subinterpreters. Before, it wasn't getting set at all.

This change does not address the broader concerns from gh-109853.

Note that here, unlike in main, we do not add PyConfig.sys_path_0, since that changes the ABI. Instead, we add _PyRuntimeState.sys_path_0.

(cherry-picked from commit a040a32)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 2 commits October 11, 2023 04:36
@ericsnowcurrently
[3.12] pythongh-109853: Fix sys.path[0] For Subinterpreters (pythongh…
5aed27b 
…-109994)

This change makes sure sys.path[0] is set properly for subinterpreters.  Before, it wasn't getting set at all.

This change does not address the broader concerns from pythongh-109853.

(cherry-picked from commit a040a32)
@ericsnowcurrently
Do not modify PyConfig. Add sys_path_0 to _PyRuntimeState instead.
d473380
@bedevere-app bedevere-app Bot added the awaiting review label Oct 11, 2023
This was referenced Oct 11, 2023
gh-109853: Fix sys.path[0] For Subinterpreters #109994
Merged
sys.path[0] Is Set Differently From the Rest of sys.path #109853
Open
ericsnowcurrently added 2 commits October 11, 2023 06:45
@ericsnowcurrently
Update python3.12.abi
ed80408
@ericsnowcurrently
Update python3.12.abi
6d13fa3
@ericsnowcurrently ericsnowcurrently assigned Yhg1s Oct 11, 2023
Yhg1s
Yhg1s reviewed Nov 20, 2023
View reviewed changes
Comment thread Include/internal/pycore_runtime.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/main.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
ericsnowcurrently added 3 commits November 20, 2023 11:54
@ericsnowcurrently
Move "sys_path_0" down, for 3.12.0 layout compatibility.
32015f8
@ericsnowcurrently
Drop XXX comments.
073e560
@ericsnowcurrently
Update python3.12.abi
f6d573c
@ericsnowcurrently
ericsnowcurrently enabled auto-merge (squash) November 27, 2023 22:15
@ericsnowcurrently
ericsnowcurrently merged commit 3135544 into python:3.12 Nov 27, 2023
@bedevere-app bedevere-app Bot removed the awaiting review label Nov 27, 2023
@ericsnowcurrently
ericsnowcurrently deleted the backport-a040a32-fix-sys-path-0 branch November 27, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yhg1s Yhg1s Yhg1s left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Yhg1s Yhg1s

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.