GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109853: Fix sys.path[0] For Subinterpreters by ericsnowcurrently · Pull Request #109994 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Sep 28, 2023

Copy link
Copy Markdown
Member

This change makes sure sys.path[0] is set properly for subinterpreters. Before, it wasn't getting set at all. This PR does not address the broader concerns from gh-109853.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 6 commits September 27, 2023 17:30
@ericsnowcurrently
Add a test.
204d712
@ericsnowcurrently
Add PyConfig.sys_path_0.
1843e11
@ericsnowcurrently
Initialize config->sys_path_0 in Py_Main().
47278d5
@ericsnowcurrently
Set sys.path[0] for subinterpreters.
d39b45b
@ericsnowcurrently
Set sys.path[0] *after* site-import.
8b909df
@ericsnowcurrently
Add a NEWS entry.
e36e0d2
@ericsnowcurrently ericsnowcurrently added the needs backport to 3.12 only security fixes label Sep 28, 2023
@bedevere-app bedevere-app Bot added the awaiting review label Sep 28, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Sep 28, 2023
sys.path[0] Is Set Differently From the Rest of sys.path #109853
Open
@ericsnowcurrently
Adjust the test.
b3501e7
@ericsnowcurrently
ericsnowcurrently force-pushed the fix-subinterp-sys-path-0 branch from b94afa7 to b3501e7 Compare September 28, 2023 20:20
ericsnowcurrently added 2 commits October 2, 2023 12:32
@ericsnowcurrently
Merge branch 'main' into fix-subinterp-sys-path-0
fe4fdc3
@ericsnowcurrently
Use the right member type.
de7237b
@ericsnowcurrently
ericsnowcurrently enabled auto-merge (squash) October 2, 2023 19:50
@ericsnowcurrently
ericsnowcurrently merged commit a040a32 into python:main Oct 2, 2023
@miss-islington

miss-islington commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Oct 2, 2023
@miss-islington

miss-islington commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

Sorry, @ericsnowcurrently, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker a040a32ea2f13f16172394d3e3e3f80f47f25a68 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned ericsnowcurrently Oct 2, 2023
@ericsnowcurrently
ericsnowcurrently deleted the fix-subinterp-sys-path-0 branch October 2, 2023 19:59
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request Oct 11, 2023
@ericsnowcurrently
[3.12] pythongh-109853: Fix sys.path[0] For Subinterpreters (pythongh…
5aed27b 
…-109994)

This change makes sure sys.path[0] is set properly for subinterpreters.  Before, it wasn't getting set at all.

This change does not address the broader concerns from pythongh-109853.

(cherry-picked from commit a040a32)
@bedevere-app

bedevere-app Bot commented Oct 11, 2023

Copy link
Copy Markdown

GH-110701 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Oct 11, 2023
ericsnowcurrently added a commit to ericsnowcurrently/cpython that referenced this pull request Oct 12, 2023
@ericsnowcurrently
[3.12] pythongh-109853: Fix sys.path[0] For Subinterpreters (pythongh…
f945ed2 
…-109994)

This change makes sure sys.path[0] is set properly for subinterpreters.  Before, it wasn't getting set at all.

This change does not address the broader concerns from pythongh-109853.

(cherry-picked from commit a040a32)
ericsnowcurrently added a commit that referenced this pull request Nov 27, 2023
@ericsnowcurrently
[3.12] gh-109853: Fix sys.path[0] For Subinterpreters (gh-109994) (gh…
3135544 
…-110701)

This change makes sure sys.path[0] is set properly for subinterpreters.  Before, it wasn't getting set at all.

This change does not address the broader concerns from gh-109853.

(cherry-picked from commit a040a32)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@ericsnowcurrently @Glyphack
pythongh-109853: Fix sys.path[0] For Subinterpreters (pythongh-109994)
b83e98c 
This change makes sure sys.path[0] is set properly for subinterpreters. Before, it wasn't getting set at all. This PR does not address the broader concerns from pythongh-109853.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ericsnowcurrently ericsnowcurrently

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.