GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-110721: Use the traceback module for PyErr_Display() and fallback to the C implementation by pablogsal · Pull Request #110702 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Oct 11, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Use the traceback module for PyErr_Display() and fallback to the C implementation #110721

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
Use the traceback module for PyErr_Display() and fallback to the C im…
290280b 
…plementation
@pablogsal
pablogsal requested a review from iritkatriel as a code owner October 11, 2023 11:22
@bedevere-app bedevere-app Bot added the awaiting review label Oct 11, 2023
@pablogsal
pablogsal requested review from ambv and lysnikolaou October 11, 2023 11:22
@pablogsal
Remove old macros
987988d
@iritkatriel

iritkatriel commented Oct 11, 2023

Copy link
Copy Markdown
Member

If no tests are failing then the fallback is not tested.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Oct 11, 2023

Copy link
Copy Markdown
Member Author

If no tests are failing then the fallback is not tested.

Yup, currently working on adapting the tests. Sorry, I forgot to mark it as a draft.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal marked this pull request as draft October 11, 2023 12:11
@bedevere-app bedevere-app Bot removed the awaiting review label Oct 11, 2023
pablogsal added 2 commits October 11, 2023 14:15
@pablogsal
Add tests for the fallback option
2292ab3
@pablogsal
fixup! Add tests for the fallback option
2ab2168
@pablogsal
pablogsal marked this pull request as ready for review October 11, 2023 14:46
@bedevere-app bedevere-app Bot added the awaiting review label Oct 11, 2023
@pablogsal
fixup! fixup! Add tests for the fallback option
e151717
@pablogsal pablogsal added skip issue skip news and removed skip issue skip news labels Oct 11, 2023
@pablogsal
fixup! fixup! fixup! Add tests for the fallback option
7d57970
@pablogsal pablogsal changed the title Use the traceback module for PyErr_Display() and fallback to the C implementation gh-110721: Use the traceback module for PyErr_Display() and fallback to the C implementation Oct 11, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 11, 2023
Use the traceback module for PyErr_Display() and fallback to the C implementation #110721
Closed
@pablogsal
fixup! fixup! fixup! fixup! Add tests for the fallback option
c812a3c
iritkatriel
iritkatriel approved these changes Oct 11, 2023
View reviewed changes
Comment thread Lib/test/test_traceback.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/traceback.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Oct 11, 2023
@iritkatriel iritkatriel added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Oct 11, 2023
@bedevere-bot

bedevere-bot commented Oct 11, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit c812a3c 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Oct 11, 2023
@pablogsal
fixup! fixup! fixup! fixup! fixup! Add tests for the fallback option
d55b7e7
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 11, 2023
@bedevere-bot

bedevere-bot commented Oct 11, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit d55b7e7 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 11, 2023
pablogsal added 2 commits October 11, 2023 17:27
@pablogsal
fixup! fixup! fixup! fixup! fixup! fixup! Add tests for the fallback …
a65d281 
…option
@pablogsal
fixup! fixup! fixup! fixup! fixup! fixup! fixup! Add tests for the fa…
4d438ec 
…llback option
iritkatriel
iritkatriel reviewed Oct 12, 2023
View reviewed changes
Comment thread Lib/test/test_sys.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 12, 2023
@bedevere-bot

bedevere-bot commented Oct 12, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 4d438ec 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 12, 2023
iritkatriel
iritkatriel reviewed Oct 12, 2023
View reviewed changes
Comment thread Python/pythonrun.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/pythonrun.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/pythonrun.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/pythonrun.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/pythonrun.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/pythonrun.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
pablogsal added 3 commits October 12, 2023 10:47
@pablogsal
fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Add tests for…
dab41fb 
… the fallback option
@pablogsal
fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Add te…
a6eb00e 
…sts for the fallback option
@pablogsal
fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup!…
d74b837 
… Add tests for the fallback option
@pablogsal
pablogsal enabled auto-merge (squash) October 12, 2023 14:22
@pablogsal
pablogsal merged commit e733136 into python:main Oct 12, 2023
@pablogsal
pablogsal deleted the traceback branch October 12, 2023 14:52
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 12, 2023
This was referenced Nov 9, 2023
Optimize the traceback Module For Core Runtime Use (and Support Custom Builds Better) #111915
Open
Support Exception-like Objects (TracebackException) For exc.__cause__ and exc.__context__ #111921
Closed
@perrinjerome perrinjerome mentioned this pull request Jan 17, 2024
Exception with broken __getattr__ causes error rendering tracebacks #113358
Closed
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@pablogsal @Glyphack
pythongh-110721: Use the traceback module for PyErr_Display() and fal…
0330b2a 
…lback to the C implementation (python#110702)
@nineteendo nineteendo mentioned this pull request Dec 3, 2024
end_offset is ignored in subclasses of SyntaxError (3.12-only) #111609
Closed
@nineteendo nineteendo mentioned this pull request Dec 11, 2024
gh-111609: Test end_offset in SyntaxError subclass #127830
Merged
@gpshead gpshead mentioned this pull request Feb 11, 2025
gh-128130: Fix unhandled keyboard interrupt data race #129975
Merged
@tideofwords tideofwords mentioned this pull request Aug 26, 2025
shadowing error with traceback module leads to unexpected code execution #138170
Closed
@moontc moontc mentioned this pull request Nov 8, 2026
pure-Python suggestion fallback differs from the C implementation #161495
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou
@ambv ambv Awaiting requested review from ambv

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@pablogsal @iritkatriel @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.