GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-108303: Move all inspect test files to `test_inspect/` (GH-109607) by sobolevn · Pull Request #110732 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Oct 11, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit 732532b)

  • Issue: Move test files into test subdirectories #108303

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
[3.12] pythongh-108303: Move all inspect test files to test_inspect/ (
f0002fe 
pythonGH-109607)

(cherry picked from commit 732532b)

Co-authored-by: Nikita Sobolev <[email protected]>
@sobolevn
sobolevn requested a review from vstinner October 11, 2023 18:15
@sobolevn
sobolevn requested review from brettcannon, encukou, ericsnowcurrently, ncoghlan and warsaw as code owners October 11, 2023 18:15
@bedevere-app bedevere-app Bot added the awaiting review label Oct 11, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 11, 2023
gh-108303: Move all inspect test files to test_inspect/ #109607
Merged
@bedevere-app bedevere-app Bot added the skip news label Oct 11, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 11, 2023
Move test files into test subdirectories #108303
Closed
@sobolevn

sobolevn commented Oct 11, 2023

Copy link
Copy Markdown
Member Author

@vstinner we need this PR to get backported: #109403

Otherwise, tests won't pass due to a findtests bug :(
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Oct 12, 2023

Copy link
Copy Markdown
Member

@vstinner we need this PR to get backported: #109403

It became impossible to backport a single regrtest change, the 3.12 and main branches became too different. So I wrote PR #110758 to copy regrtest files from main to 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn sobolevn closed this Oct 13, 2023
@sobolevn sobolevn reopened this Oct 13, 2023
@vstinner

vstinner commented Oct 13, 2023

Copy link
Copy Markdown
Member

Can you please rebase your PR on the 3.12 branch to solve the libregrtest merge conflict?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
Merge
e6cd317
@sobolevn

sobolevn commented Oct 13, 2023

Copy link
Copy Markdown
Member Author

Should be good now! Thanks a lot for your backport PRs! They are really helpful.
vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 0102faf into python:3.12 Oct 13, 2023
@bedevere-app bedevere-app Bot removed the awaiting review label Oct 13, 2023
@vstinner vstinner added the needs backport to 3.11 only security fixes label Oct 13, 2023
@miss-islington

miss-islington commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

Sorry, @sobolevn and @vstinner, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 0102faf0cac107fd4d0fde9902560c7cf0a3be9d 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned vstinner Oct 13, 2023
@vstinner

vstinner commented Oct 13, 2023

Copy link
Copy Markdown
Member

I was feeling lucky and tried automated backport...

@sobolevn: Do you want to try to backport to 3.11? Otherwise, I can try to backport.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn

sobolevn commented Oct 13, 2023

Copy link
Copy Markdown
Member Author

Will do tomorrow.
vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity ZeroIntensity removed the needs backport to 3.11 only security fixes label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner
@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@encukou encukou Awaiting requested review from encukou encukou is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@vstinner vstinner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sobolevn @vstinner @miss-islington @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.