GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-110756: Sync regrtest with main branch by vstinner · Pull Request #110758 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Oct 12, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Copy files from main to this branch:

  • Lib/test/libregrtest/*.py
  • Lib/test/init.py
  • Lib/test/main.py
  • Lib/test/autotest.py
  • Lib/test/pythoninfo.py
  • Lib/test/regrtest.py
  • Lib/test/test_regrtest.py

Do not modify scripts running tests such as Makefile.pre.in, .github/workflows/build.yml or Tools/scripts/run_tests.py: do not use --fast-ci and --slow-ci in this change.

Changes:

  • SPLITTESTDIRS: don't include test_inspect.
  • Add utils.process_cpu_count() using len(os.sched_getaffinity(0)).
  • test_regrtest doesn't use @support.without_optimizer which doesn't exist in Python 3.12.
  • Add support.set_sanitizer_env_var().
  • Update test_faulthandler to use support.set_sanitizer_env_var().
  • Issue: regrtest: Synchronize regrtest in 3.11 and 3.12 branches with main branch #110756

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-110756: Sync regrtest with main branch
c27abfb 
Copy files from main to this branch:

* Lib/test/libregrtest/*.py
* Lib/test/__init__.py
* Lib/test/__main__.py
* Lib/test/autotest.py
* Lib/test/pythoninfo.py
* Lib/test/regrtest.py
* Lib/test/test_regrtest.py

Do not modify scripts running tests such as Makefile.pre.in,
.github/workflows/build.yml or Tools/scripts/run_tests.py: do not use
--fast-ci and --slow-ci in this change.

Changes:

* SPLITTESTDIRS: don't include test_inspect.
* Add utils.process_cpu_count() using len(os.sched_getaffinity(0)).
* test_regrtest doesn't use @support.without_optimizer which doesn't
  exist in Python 3.12.
* Add support.set_sanitizer_env_var().
* Update test_faulthandler to use support.set_sanitizer_env_var().
@bedevere-app bedevere-app Bot added the awaiting review label Oct 12, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 12, 2023
regrtest: Synchronize regrtest in 3.11 and 3.12 branches with main branch #110756
Closed
@vstinner vstinner added tests Tests in the Lib/test dir skip news labels Oct 12, 2023
@vstinner

vstinner commented Oct 12, 2023

Copy link
Copy Markdown
Member Author

cc @serhiy-storchaka @sobolevn

The main drawback of this approach (copy files) is that I skipped all Changelog entries. Sorry, that's just too much work for me :-( You can look at the Changelog in the main branch for details: https://docs.python.org/dev/whatsnew/changelog.html#tests

I plan to merge this change once tests pass, only you see a good reason to not update regrtest this way.

Since I will do the same for 3.11, here are my notes on how I created this PR:

cd ../3.12
git switch -c regrtest12
/bin/cp -Rf ../main/Lib/test/libregrtest/*.py  Lib/test/libregrtest/
git add Lib/test/libregrtest/*py

/bin/cp -Rf ../main/Lib/test/pythoninfo.py  Lib/test/pythoninfo.py 
/bin/cp -Rf ../main/Lib/test/autotest.py  Lib/test/
/bin/cp -Rf ../main/Lib/test/__init__.py  Lib/test/
/bin/cp -Rf ../main/Lib/test/__main__.py  Lib/test/
/bin/cp -Rf ../main/Lib/test/regrtest.py  Lib/test/
/bin/cp -Rf ../main/Lib/test/test_regrtest.py  Lib/test/

meld Lib/test/test_faulthandler.py  ../main/Lib/test/test_faulthandler.py   # in fact at the end, both files are the same

git ci -a  # create the commit
./python -m test -j0 test_regrtest test_support
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Oct 12, 2023

Copy link
Copy Markdown
Member Author

Do not modify scripts running tests such as Makefile.pre.in, .github/workflows/build.yml or Tools/scripts/run_tests.py: do not use --fast-ci and --slow-ci in this change.

We can consider backporting these changes later, but if we do that, I would prefer to do it separately.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Oct 12, 2023
[3.12] gh-108303: Move all inspect test files to test_inspect/ (GH-109607) #110732
Merged
serhiy-storchaka
serhiy-storchaka approved these changes Oct 12, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Oct 12, 2023
@vstinner
vstinner merged commit 4b7a12d into python:3.12 Oct 12, 2023
@vstinner
vstinner deleted the regrtest12 branch October 12, 2023 20:03
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 12, 2023
@vstinner

vstinner commented Oct 12, 2023

Copy link
Copy Markdown
Member Author

Ah, I missed some bits: PR #110779.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner added a commit to vstinner/cpython that referenced this pull request Oct 12, 2023
@vstinner
pythongh-110756: Sync regrtest with main branch (python#110758)
f452cdf 
pythongh-110756: Sync regrtest with main branch

Copy files from main to this branch:

* Lib/test/libregrtest/*.py
* Lib/test/__init__.py
* Lib/test/__main__.py
* Lib/test/autotest.py
* Lib/test/pythoninfo.py
* Lib/test/regrtest.py
* Lib/test/test_regrtest.py

Copy also changes from:

* Lib/test/support/__init__.py
* Lib/test/support/os_helper.py
* Lib/test/support/testresult.py
* Lib/test/support/threading_helper.py
* Lib/test/test_support.py

Do not modify scripts running tests such as Makefile.pre.in,
.github/workflows/build.yml or Tools/scripts/run_tests.py: do not use
--fast-ci and --slow-ci in this change.

Changes:

* SPLITTESTDIRS: don't include test_inspect.
* Add utils.process_cpu_count() using len(os.sched_getaffinity(0)).
* test_regrtest doesn't use @support.without_optimizer which doesn't
  exist in Python 3.11.
* Add support.set_sanitizer_env_var().
* Update test_faulthandler to use support.set_sanitizer_env_var().
* @support.without_optimizer doesn't exist in 3.11.
* Add support.Py_DEBUG.
* regrtest.refleak: 3.11 doesn't have sys.getunicodeinternedsize.
@bedevere-app

bedevere-app Bot commented Oct 12, 2023

Copy link
Copy Markdown

GH-110781 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner added a commit that referenced this pull request Oct 12, 2023
@vstinner
gh-110756: Sync regrtest with main branch (#110758) (#110781)
26748ed 
Copy files from main to this branch:

* Lib/test/libregrtest/*.py
* Lib/test/__init__.py
* Lib/test/__main__.py
* Lib/test/autotest.py
* Lib/test/pythoninfo.py
* Lib/test/regrtest.py
* Lib/test/test_regrtest.py

Copy also changes from:

* Lib/test/support/__init__.py
* Lib/test/support/os_helper.py
* Lib/test/support/testresult.py
* Lib/test/support/threading_helper.py
* Lib/test/test_support.py

Do not modify scripts running tests such as Makefile.pre.in,
.github/workflows/build.yml or Tools/scripts/run_tests.py: do not use
--fast-ci and --slow-ci in this change.

Changes:

* SPLITTESTDIRS: don't include test_inspect.
* Add utils.process_cpu_count() using len(os.sched_getaffinity(0)).
* test_regrtest doesn't use @support.without_optimizer which doesn't
  exist in Python 3.11.
* Add support.set_sanitizer_env_var().
* Update test_faulthandler to use support.set_sanitizer_env_var().
* @support.without_optimizer doesn't exist in 3.11.
* Add support.Py_DEBUG.
* regrtest.refleak: 3.11 doesn't have sys.getunicodeinternedsize.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.