GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-110774: allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCase by graingert · Pull Request #110776 · python/cpython

Conversation

@graingert

@graingert graingert commented Oct 12, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Support setting the loop_factory in IsolatedAsyncioTestCase #110774

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@graingert
allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCase
0ed7c50
@graingert graingert changed the title allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCase gh-10774: allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCase Oct 12, 2023
@graingert graingert changed the title gh-10774: allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCase gh-110774: allow setting the Runner(loop_factory=...) from IsolatedAsyncioTestCase Oct 12, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 12, 2023
Support setting the loop_factory in IsolatedAsyncioTestCase #110774
Closed
graingert
graingert commented Oct 12, 2023
View reviewed changes
Comment thread Doc/library/unittest.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
graingert
graingert commented Oct 12, 2023
View reviewed changes
Comment thread Doc/library/unittest.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
graingert
graingert commented Oct 12, 2023
View reviewed changes
Comment thread Doc/library/unittest.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
graingert
graingert commented Oct 12, 2023
View reviewed changes
Comment thread Doc/library/unittest.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
graingert
graingert commented Oct 12, 2023
View reviewed changes
Comment thread Lib/test/test_unittest/test_async_case.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
graingert and others added 3 commits October 12, 2023 16:20
@graingert
test IsolatedAsyncioTestCase.loop_factory
216dc96
@graingert
document loop_factory attribute
a05085f
@blurb-it @graingert
📜🤖 Added by blurb_it.
0fbb894
@graingert
graingert force-pushed the unittest-loop-factory branch from 47669b3 to 0fbb894 Compare October 12, 2023 15:20
@graingert
graingert marked this pull request as ready for review October 12, 2023 15:32
@bedevere-app bedevere-app Bot added the awaiting review label Oct 12, 2023
@ambv
Merge branch 'main' into unittest-loop-factory
63b940c
willingc
willingc approved these changes Oct 13, 2023
View reviewed changes

@willingc willingc left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @graingert. This looks good to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Oct 13, 2023
@willingc
Merge branch 'main' into unittest-loop-factory
335e26d
gvanrossum
gvanrossum approved these changes Oct 31, 2023
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gvanrossum
gvanrossum merged commit 7705306 into python:main Oct 31, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 31, 2023
@graingert
graingert deleted the unittest-loop-factory branch October 31, 2023 22:32
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
@graingert @ambv
@willingc @FullteaR
pythongh-110774: allow setting the Runner(loop_factory=...) from Isol…
3512380 
…atedAsyncioTestCase (python#110776)


Co-authored-by: Łukasz Langa <[email protected]>
Co-authored-by: Carol Willing <[email protected]>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@graingert @ambv
@willingc @aisk
pythongh-110774: allow setting the Runner(loop_factory=...) from Isol…
73dc956 
…atedAsyncioTestCase (python#110776)


Co-authored-by: Łukasz Langa <[email protected]>
Co-authored-by: Carol Willing <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@graingert @ambv
@willingc @Glyphack
pythongh-110774: allow setting the Runner(loop_factory=...) from Isol…
47d7b80 
…atedAsyncioTestCase (python#110776)


Co-authored-by: Łukasz Langa <[email protected]>
Co-authored-by: Carol Willing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willingc willingc willingc approved these changes
@gvanrossum gvanrossum gvanrossum approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@graingert @willingc @gvanrossum @ambv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.