GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-110793: add GitHub Actions job that runs tests after installing by FFY00 · Pull Request #110794 · python/cpython

Conversation

@FFY00

@FFY00 FFY00 commented Oct 13, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Add GitHub Actions job that runs the tests in an installed Python #110793

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@FFY00
pythonGH-110793: add Github action job that runs tests after installing
8753599 
Signed-off-by: Filipe Laíns <[email protected]>
@FFY00 FFY00 added the skip news label Oct 13, 2023
@FFY00
FFY00 requested review from ezio-melotti and hugovk as code owners October 13, 2023 01:34
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 13, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 13, 2023
Add GitHub Actions job that runs the tests in an installed Python #110793
Closed
FFY00 added 2 commits October 13, 2023 03:21
@FFY00
debug
096ad48 
Signed-off-by: Filipe Laíns <[email protected]>
@FFY00
debug
d7c4fc3 
Signed-off-by: Filipe Laíns <[email protected]>
@hugovk hugovk changed the title GH-110793: add Github action job that runs tests after installing GH-110793: add GitHub Actions job that runs tests after installing Oct 13, 2023
FFY00 added 2 commits October 13, 2023 07:08
@FFY00
debug
c379860 
Signed-off-by: Filipe Laíns <[email protected]>
@FFY00
try --with-openssl-rpath
7cdc98f 
Signed-off-by: Filipe Laíns <[email protected]>
@FFY00

FFY00 commented Oct 13, 2023

Copy link
Copy Markdown
Member Author

The job is now successful, this is ready for review. I'd still wait a little bit before merging, to see if there is any discussion on the issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@FFY00
don't cd into the builddir when running the tests
0775658 
Signed-off-by: Filipe Laíns <[email protected]>
sobolevn
sobolevn reviewed Oct 13, 2023
View reviewed changes
Comment thread .github/workflows/build.yml
--with-openssl-rpath
- name: Build CPython out-of-tree
working-directory: ${{ env.CPYTHON_BUILDDIR }}
run: make -j4

@sobolevn sobolevn Oct 13, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we assume that 4 is a good number (other build jobs also do this)?
Снимок экрана 2023-10-13 в 11 04 43

Should we switch to -j$(nproc) / $(sysctl -n hw.ncpu)?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@FFY00 FFY00 Oct 13, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's the number of threads for Linux and Windows.

In this PR, I just copied the other jobs, so this comes from there. We can do the improvements you are suggesting (would also be nicer when running locally with act for eg), but it should probably be in a different PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sobolevn reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@hugovk hugovk Oct 15, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed something for another PR, but worth investigating.

I've sometimes done a test on my fork with different numbers of jobs in a matrix.

For example, with macOS: make buildbottest TESTOPTS="-j${{ matrix.jobs }} -uall,-cpu"

  • hugovk@05b0451
  • https://github.com/hugovk/cpython/actions/runs/6361030227

Shows ~4 is about right:

image

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ezio-melotti reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@hugovk

hugovk commented Oct 15, 2023

Copy link
Copy Markdown
Member

build_ubuntu and build_ubuntu_installed have a lot of duplicate lines: ~60/66 are identical.

build.yml is getting too long, it's over 700 lines!

If we go for this, let's do them as reusable workflows:

  • https://docs.github.com/en/actions/using-workflows/reusing-workflows

Examples:

  • https://github.com/python/cpython/blob/main/.github/workflows/reusable-docs.yml
  • https://github.com/python-pillow/Pillow/blob/main/.github/workflows/wheels.yml
    • https://github.com/python-pillow/Pillow/blob/main/.github/workflows/wheels-linux.yml
    • https://github.com/python-pillow/Pillow/blob/main/.github/workflows/wheels-macos.yml

Possibly also build_ubuntu_ssltests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Oct 15, 2023

Copy link
Copy Markdown
Member

Let's also consider the CI time.

This job is 26m, compared to 14m for the standard Ubuntu one. Plus we recently added 3 x CIFuzz which are 21-29m:

image

https://github.com/python/cpython/actions/runs/6505589398
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@FFY00

FFY00 commented Oct 16, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

This job is 26m, compared to 14m for the standard Ubuntu one. Plus we recently added 3 x CIFuzz which are 21-29m:

I noticed make test adds a couple options, I think that's why it takes less time.

./python -u -W default -bb -E -m test --fast-ci --timeout= --dont-add-python-opts

Let's try adding them to the new job.

build_ubuntu and build_ubuntu_installed have a lot of duplicate lines: ~60/66 are identical.

build.yml is getting too long, it's over 700 lines!

If we go for this, let's do them as reusable workflows:

Agreed. Do you want to implement that in this PR or in a followup one?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Oct 16, 2023

Copy link
Copy Markdown
Member

It would be good in this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk mentioned this pull request Oct 20, 2023
gh-111062: Add nogil build test on GitHub Actions #111060
Closed
@corona10 corona10 mentioned this pull request Oct 29, 2023
Add GitHub Action for checking free-threaded build #111062
Closed
@github-actions

github-actions Bot commented Apr 14, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 14, 2026
@StanFromIreland StanFromIreland mentioned this pull request Jun 30, 2026
gh-110793: Add CI job that runs tests with an installed build #152664
Merged
@StanFromIreland

StanFromIreland commented Aug 10, 2026

Copy link
Copy Markdown
Member

Completed in 8a4ee5c.
hugovk reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland StanFromIreland closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn left review comments
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@FFY00 @hugovk @StanFromIreland @sobolevn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.