GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-110793: Add CI job that runs tests with an installed build by StanFromIreland · Pull Request #152664 · python/cpython

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Jun 30, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This takes into consideration the suggestions on #110794. As for timing, I picked the fastest runner available, we'll have to see how long it takes. I presume it won't be slower than the Windows builds, however. Looking at the three runs on this PR, it takes about nine minutes (however, that does include two 30s timeouts). That's far faster then our longest runs which are around half an hour.

  • Issue: Add GitHub Actions job that runs the tests in an installed Python #110793

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@StanFromIreland
pythongh-110793: Add CI job that runs tests with an installed build
9a73e26
@StanFromIreland
StanFromIreland requested review from FFY00 and sobolevn June 30, 2026 09:52
@StanFromIreland
StanFromIreland requested review from AA-Turner, JacobCoffee, ezio-melotti, hugovk, itamaro and webknjaz as code owners June 30, 2026 09:52
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 30, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 30, 2026
Add GitHub Actions job that runs the tests in an installed Python #110793
Closed
@StanFromIreland StanFromIreland added the skip news label Jun 30, 2026
@StanFromIreland
Pass OS like we do for reusable-ubunut
caf7b26
@StanFromIreland

StanFromIreland commented Jun 30, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

This is currently blocked by #152653 (failing test_sys).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland added 2 commits June 30, 2026 12:15
@StanFromIreland
Run pythoninfo on installed, and run test w/ python${LDVERSION}
4d5bbd0
@StanFromIreland
Merge branch 'main' into Reusable-Ubuntu-(Installed)
86e64ee
sobolevn
sobolevn reviewed Jun 30, 2026
View reviewed changes
Comment thread .github/workflows/reusable-install.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland
StanFromIreland requested a review from sobolevn June 30, 2026 15:17
StanFromIreland added 2 commits July 20, 2026 12:04
@StanFromIreland
Merge branch 'main' into Reusable-Ubuntu-(Installed)
7961ebb
@StanFromIreland
Bump Ubuntu version
e62fc5a
@StanFromIreland

StanFromIreland commented Aug 7, 2026

Copy link
Copy Markdown
Member Author

Hi! Anyone have any comments on this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
webknjaz
webknjaz approved these changes Aug 7, 2026
View reviewed changes

@webknjaz webknjaz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. I have an inline question, though. Non-blocking.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread .github/workflows/reusable-install.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/reusable-install.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland
Sviatoslav's review
a0cb79c
itamaro
itamaro reviewed Aug 9, 2026
View reviewed changes

@itamaro itamaro left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you have an example of a breakage that would be caught by this CI job, and not by any other existing CI job?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread .github/workflows/build.yml Outdated
if: needs.build-context.outputs.run-ubuntu == 'true'
uses: ./.github/workflows/reusable-install.yml
with:
os: ubuntu-26.04-arm

@itamaro itamaro Aug 9, 2026

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why use arm specifically? (vs plain x86_64 ubuntu)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@StanFromIreland StanFromIreland Aug 9, 2026

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The architecture shouldn't really mater, however, it's generally the fastest runner, that's why we enable -ucpu when running tests on it:

cpython/.github/workflows/build.yml

Lines 236 to 240 in 998b890

# Enable CPU-intensive tests on ARM (default build only)
- os: ubuntu-26.04-arm
bolt: false
free-threading: false
test-opts: '-u cpu'

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
itamaro reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@webknjaz webknjaz Aug 10, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little late to the party but I'd like to state FTR that in the future we should be adding an explicit comment explaining such choices. The motivation may otherwise be difficult to trace transparently and figure out, when troubleshooting something in the future.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread .github/workflows/reusable-install.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland

StanFromIreland commented Aug 9, 2026

Copy link
Copy Markdown
Member Author

do you have an example of a breakage that would be caught by this CI job, and not by any other existing CI job?

For example, #152653 which prompted this. I don't know any more specific examples of the top of my head, but there have been quite a few cases of this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland
Drop --with-pydebug
d558219
@StanFromIreland
StanFromIreland requested a review from itamaro August 9, 2026 19:09
itamaro
itamaro approved these changes Aug 9, 2026
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Aug 9, 2026
hugovk
hugovk reviewed Aug 10, 2026
View reviewed changes
Comment thread .github/workflows/build.yml Outdated
Comment on lines +390 to +391
with:
os: ubuntu-26.04-arm

@hugovk hugovk Aug 10, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not varying this, so it doesn't need to be a variable.

Suggested change
with:
os: ubuntu-26.04-arm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@webknjaz webknjaz Aug 10, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I think things like this might be useful in terms of surfacing the same type of information on the same level of abstraction (the calling workflow). But it's probably something to be debated in a separate refactoring effort anyway..

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread .github/workflows/reusable-install.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/reusable-install.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/reusable-install.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/reusable-install.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/reusable-install.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/reusable-install.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread .github/workflows/build.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland and others added 2 commits August 10, 2026 10:04
@StanFromIreland @hugovk
Hugo's review
3092b9c 
Co-authored-by: Hugo van Kemenade <[email protected]>
@StanFromIreland
Little reordering for consistency
b3cc2c7
@StanFromIreland
StanFromIreland requested a review from hugovk August 10, 2026 09:06
hugovk
hugovk approved these changes Aug 10, 2026
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Noting for future reference, this new job takes around 6 minutes, much quicker than the current bottleneck (Windows x86 FT) at almost 30 minutes.

Image

https://github.com/python/cpython/actions/runs/31373039414/job/93406279180?pr=152664

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@StanFromIreland
StanFromIreland merged commit 8a4ee5c into python:main Aug 10, 2026
52 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland
StanFromIreland deleted the Reusable-Ubuntu-(Installed) branch August 10, 2026 11:15
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 10, 2026
@StanFromIreland

StanFromIreland commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

Thanks for all the reviews!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland StanFromIreland added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Aug 10, 2026
@miss-islington-app

miss-islington-app Bot commented Aug 10, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Aug 10, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Aug 10, 2026

Copy link
Copy Markdown

Thanks @StanFromIreland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Aug 10, 2026

Copy link
Copy Markdown

GH-155482 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Aug 10, 2026
@bedevere-app

bedevere-app Bot commented Aug 10, 2026

Copy link
Copy Markdown

GH-155483 is a backport of this pull request to the 3.15 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Aug 10, 2026
@bedevere-app

bedevere-app Bot commented Aug 10, 2026

Copy link
Copy Markdown

GH-155484 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Aug 10, 2026
hugovk added a commit that referenced this pull request Aug 10, 2026
@miss-islington @StanFromIreland @hugovk
[3.15] gh-110793: Add CI job that runs tests with an installed build (G…
be93a4a 
…H-152664) (#155483)

Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
StanFromIreland added a commit that referenced this pull request Aug 10, 2026
@miss-islington @StanFromIreland @hugovk
[3.14] gh-110793: Add CI job that runs tests with an installed build (G…
142b007 
…H-152664) (#155484)

(cherry picked from commit 8a4ee5c)

Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
StanFromIreland added a commit that referenced this pull request Aug 10, 2026
@miss-islington @StanFromIreland @hugovk
[3.13] gh-110793: Add CI job that runs tests with an installed build (G…
a46a67b 
…H-152664) (#155482)

(cherry picked from commit 8a4ee5c)

Co-authored-by: Stan Ulbrych <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
mbeijen pushed a commit to mbeijen/cpython that referenced this pull request Aug 14, 2026
@StanFromIreland @hugovk @mbeijen
pythongh-110793: Add CI job that runs tests with an installed build (p…
2b1650d 
…ython#152664)

Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webknjaz webknjaz webknjaz approved these changes
@itamaro itamaro itamaro approved these changes
@hugovk hugovk hugovk approved these changes
@FFY00 FFY00 Awaiting requested review from FFY00
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@JacobCoffee JacobCoffee Awaiting requested review from JacobCoffee JacobCoffee is a code owner
@sobolevn sobolevn Awaiting requested review from sobolevn

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@StanFromIreland @itamaro @webknjaz @hugovk @sobolevn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.