GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-110392: Fix tty functions (GH-110642) by miss-islington · Pull Request #110853 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Oct 14, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • tty.setraw() and tty.setcbreak() previously returned partially modified
    list of the original tty attributes. Now they return the correct list of
    the original tty attributes

  • tty.cfmakeraw() and tty.cfmakecbreak() now make a copy of the list of
    special characters before modifying it.
    (cherry picked from commit 84e2096)

Co-authored-by: Serhiy Storchaka [email protected]

  • Issue: tty.setraw() and tty.setcbreak() return partially modified original attributes #110392

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@serhiy-storchaka @miss-islington
pythongh-110392: Fix tty functions (pythonGH-110642)
f1c5933
* tty.setraw() and tty.setcbreak() previously returned partially modified
  list of the original tty attributes. Now they return the correct list of
  the original tty attributes

* tty.cfmakeraw() and tty.cfmakecbreak() now make a copy of the list of
  special characters before modifying it.
(cherry picked from commit 84e2096)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app bedevere-app Bot mentioned this pull request Oct 14, 2023
tty.setraw() and tty.setcbreak() return partially modified original attributes #110392
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Oct 14, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 14, 2023
gh-110392: Fix tty functions #110642
Merged
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) October 14, 2023 06:06
@serhiy-storchaka
serhiy-storchaka merged commit 0164832 into python:3.12 Oct 14, 2023
@bedevere-app bedevere-app Bot removed the awaiting review label Oct 14, 2023
@miss-islington
miss-islington deleted the backport-84e2096-3.12 branch October 14, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.