GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tty.setraw() and tty.setcbreak() return partially modified original attributes · Issue #110392 · python/cpython

tty.setraw() and tty.setcbreak() return partially modified original attributes #110392

New issue
Copy link
New issue
Copy link
Closed
Closed
tty.setraw() and tty.setcbreak() return partially modified original attributes#110392
Copy link
Assignees
serhiy-storchaka
Labels
3.12only security fixesonly security fixes3.13only security fixesonly security fixestype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

Description

@serhiy-storchaka
serhiy-storchaka
opened on Oct 5, 2023
Issue body actions

Bug report

According to the documentation they save the original result of termios.tcgetattr() and return it. But while making a copy of the attribute list before modifying it they do not take in account that it contains a reference to original cc list and modify it. So these functions return a list which contains original values and modified cc list.

These functions started returning the attribute list in #85984 (486bc8e).

The question: who should make a copy of the internal list: setraw() before passing it to cfmakeraw(), or cfmakeraw() itself?

cc @gpshead

Linked PRs

  • gh-110392: Fix tty functions #110642
  • [3.12] gh-110392: Fix tty functions (GH-110642) #110853

Activity

  1. serhiy-storchaka
    added
    type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error
    3.12only security fixesonly security fixes
    3.13only security fixesonly security fixes
    on Oct 5, 2023
  2. serhiy-storchaka
    self-assigned this
    on Oct 5, 2023
  3. serhiy-storchaka
    added 2 commits that reference this issue on Oct 10, 2023

    pythongh-110392: Fix tty functions

    2a4f260

    gh-110392: Fix tty functions (GH-110642)

    84e2096
  4. miss-islington
    added a commit that references this issue on Oct 14, 2023

    pythongh-110392: Fix tty functions (pythonGH-110642)

    f1c5933
  5. serhiy-storchaka
    added a commit that references this issue on Oct 14, 2023

    [3.12] gh-110392: Fix tty functions (GH-110642) (GH-110853)

    0164832
  6. serhiy-storchaka
    closed this as completedon Oct 14, 2023
  7. aisk
    added a commit that references this issue on Feb 11, 2024

    pythongh-110392: Fix tty functions (pythonGH-110642)

    9adf682
  8. Glyphack
    added a commit that references this issue on Sep 2, 2024

    pythongh-110392: Fix tty functions (pythonGH-110642)

    a22e2dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

  • @serhiy-storchaka
    serhiy-storchaka

Labels

3.12only security fixesonly security fixes3.13only security fixesonly security fixestype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    You are visitor 01402503 — GeezerVison does not store the pages you look up.
    Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.